Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client-side version handler #207

Open
ScriptedAlchemy opened this issue Nov 24, 2020 · 2 comments
Open

Improve client-side version handler #207

ScriptedAlchemy opened this issue Nov 24, 2020 · 2 comments
Assignees

Comments

@ScriptedAlchemy
Copy link
Member

ScriptedAlchemy commented Nov 24, 2020

dashboard-plugin/client-version is functional, but needs to be improved.

Functions need to be more resilient - code needs to be DRYed out further

We should consider Template from webpack to assist in writing function templates.

Look in webpack code and search for Template.asString to Template.baseFunction, a lot of templating tools are available to make it easier to format and wring blocks of strings.

What happens if a remote fails, we would need to think about what pattern could be implemented - like trying to load another version, when that promise rejects

We want to be able to track the scripts in the best way possible when injecting them.

@hamatoyogi
Copy link

@ScriptedAlchemy ran through the video and added a new version to dsl (0.3.1):

  • did see the new remoteEntry file in `dist
  • tried to change the Default version on the DSL application screen (which showed 0.3.1) to 0.3.0 and got this error:
    image
  • not sure this should work yet 🤷🏽‍♂️

also, went to home application screen:

  • changed dsl to version 3.0.0
  • got this in the console:
    image
  • which i'd expect to have shown that I'm on remote version 0.3.0.
  • I'm not sure this is working as expected:
    image
    (on the left you see I've chosen 0.3.1 and on the right I'm getting logged that 0.3.0 is loaded)

@hamatoyogi
Copy link

I've pulled and merged the latest release branch, and I branched out of there. Haven't made any changes yet.
Would be good to know if I did something wrong, or missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants