Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save messages that failed to send into logs #2903

Open
PlagueTheWise opened this issue Nov 26, 2020 · 5 comments
Open

Save messages that failed to send into logs #2903

PlagueTheWise opened this issue Nov 26, 2020 · 5 comments
Labels
feature request logviewer Requires code to be changed in logviewer as well priority: low Something that's not on top of the list. You are free to submit a pull request though

Comments

@PlagueTheWise
Copy link

Hello, I am a moderator in a server that uses your mod mail bot (Warzone LFG) and I have noticed a small issue with the bot not saving undelivered responses to the logs. It happens when an user leaves the mutual server after a thread has already been opened and us sending a reply - that reply doesn't get delivered to the user and then the issue I have: the reply that could not be delivered doesn't get saved in the Mod Mail logs. It's a pretty small thing but it is nice to have it saved in the logs for context and future reference. Thanks!

@StephenDaDev
Copy link
Member

StephenDaDev commented Nov 26, 2020

Hi There! Thanks for reaching out to suggest something for Modmail, we love hearing your suggestions as it helps us shape the bot to what our users want it to be. However this is a logviewer related suggestion, therefore it belongs on the repo kyb3r/logviewer.

I stand corrected, it is not.

@fourjr
Copy link
Collaborator

fourjr commented Nov 27, 2020

If a message is undelivered, why should it be saved in the logs?

@PlagueTheWise
Copy link
Author

In the case of the user contacting us again or to know what the response was in general for future reference or context when looking back at a past thread. I understand if you do not wish to implement that feature, I just thought it would be useful to have.

@fourjr fourjr changed the title Mod Mail feature request Save messages that failed to send into logs Nov 30, 2020
@fourjr fourjr added config suggestion New config option feature request logviewer Requires code to be changed in logviewer as well priority: low Something that's not on top of the list. You are free to submit a pull request though labels Nov 30, 2020
@fourjr
Copy link
Collaborator

fourjr commented Nov 30, 2020

My idea of such a feature would be with a config variable to toggle preference. Since this requires the modification of logviewer code, the priority will be low

@ririko5834
Copy link

Also can you add that message edits will be logged too. And if message was deleted add there some badge that it was deleted.

@Taaku18 Taaku18 removed the config suggestion New config option label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request logviewer Requires code to be changed in logviewer as well priority: low Something that's not on top of the list. You are free to submit a pull request though
Projects
None yet
Development

No branches or pull requests

5 participants