Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace @esm-bundle/chai with regular chai package #2635

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonkoops
Copy link

@jonkoops jonkoops commented Feb 3, 2024

Closes #2633

Copy link

changeset-bot bot commented Feb 3, 2024

⚠️ No Changeset found

Latest commit: edd07e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@koddsson
Copy link
Contributor

koddsson commented Feb 7, 2024

Looks good to me! I couldn't get this working without converting the package to ESM first so I'm surprised that this is working. If CI is green I'll merge it :)

@jonkoops
Copy link
Author

jonkoops commented Feb 7, 2024

Looks good to me! I couldn't get this working without converting the package to ESM first so I'm surprised that this is working.

We're using the regular package in Leaflet, but we are using plain import maps rather than --node-resolve, not sure if that affects things.

@jonkoops
Copy link
Author

jonkoops commented Feb 7, 2024

Tests are failing, looks like the path to chai is re-written to node_modules/chai/index.js, but this is not correct. The main entry of chai is supposed to resolve to node_modules/chai/chai.js. Looks like this might be a bug in the Node.js-style resolution?

Note that Node.js' resolution mechanism is documented extensively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use normal chai package over @esm-bundle/chai
2 participants