Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command calls undefined getContainer function #138

Open
carlos-granados opened this issue Nov 17, 2020 · 4 comments
Open

Command calls undefined getContainer function #138

carlos-granados opened this issue Nov 17, 2020 · 4 comments

Comments

@carlos-granados
Copy link
Contributor

The setLoggerService function in the run command calls the getContainer() function which no longer exists because the command no longer extends the ContainerAwareCommand class

@mmucklo
Copy link
Owner

mmucklo commented Nov 20, 2020

@carlos-granados can you try with the latest version?

@carlos-granados
Copy link
Contributor Author

@mmucklo yes, all good now :-)

@carlos-granados
Copy link
Contributor Author

@mmucklo Actually, it would be useful if the runLoop, logger and container properties were protected instead of private. This would allow us to easily extend this command.

@carlos-granados
Copy link
Contributor Author

Either that or add some getters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants