Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsdom to 16.5.0 to remove security issues #820

Closed
wants to merge 2 commits into from

Conversation

Evangelink
Copy link

@Evangelink Evangelink commented Oct 24, 2022

Fixes #818

When doing a local build, the logs were saying that the package-lock.json files were using old mechanism and will be auto-updated to new format.

@Evangelink Evangelink changed the title Auto update package-lock files Update jsdom to 16.5.0 to remove security issues Oct 24, 2022
@Evangelink
Copy link
Author

Hi @mmanela, would it be possible for you to review this PR? It would help us to be able to remove this security issue from our radar.

@Evangelink
Copy link
Author

Ping @mmanela

@mmanela
Copy link
Owner

mmanela commented Nov 8, 2022

Sorry for the delay. Did you validate if everything works? I remember years ago I had looked at a JSDOM updated and it broke a lot. @Evangelink

@Evangelink
Copy link
Author

I haven't done any extra manual test no. I assumed that there was integration tests that would catch such issue. Happy to run any test but I would need some guidance from you because I am not really using your tool per say. I am part of the MS test platform team and we simply have some acceptance tests using your tool to ensure we don't break compatibility for JS testing (meaning that I am not actively using this tool). I am happy to learn because I expect to be doing regular PRs here for security reasons.

@mmanela
Copy link
Owner

mmanela commented Nov 9, 2022

The other thing to consider @Evangelink is that this is not really a vulnerability that need actioning. Chutzpah is not a server application and is just run local client app. The risk for exposure is super minimal. Chutzpah gets flagged for these things though since the libs it uses may be used in web sites that are actually exploitable.

@Evangelink
Copy link
Author

Sadly it will be harder for us to investigate, justify and ensure that vulnerabilities can't be exploited in any way rather than "simply" bumping the dependencies. Although I understand this will generate some extra review/release job on your side.

@Evangelink Evangelink closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability CVE-2021-20066
2 participants