Skip to content

Commit

Permalink
Don't force the latest version of grpc and protobuf
Browse files Browse the repository at this point in the history
Why we previously forced versions?
See #723

Why we don't need that anymore?
See php/web-pecl#92

Test: grpc, protobuf
  • Loading branch information
mlocati committed Sep 6, 2023
1 parent 7618bd4 commit ee1b129
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions install-php-extensions
Original file line number Diff line number Diff line change
Expand Up @@ -2855,10 +2855,6 @@ installRemoteModule() {
esac
fi
fi
if test -z "$installRemoteModule_version"; then
# See https://github.com/protocolbuffers/protobuf/issues/10619
installRemoteModule_version=1.57.0
fi
if test -z "$installRemoteModule_version" || test "$installRemoteModule_version" = 1.35.0; then
case "$DISTRO_VERSION" in
[email protected])
Expand Down Expand Up @@ -3181,9 +3177,6 @@ installRemoteModule() {
if test -z "$installRemoteModule_version"; then
if test $PHP_MAJMIN_VERSION -le 506; then
installRemoteModule_version=3.12.4
else
# See https://github.com/protocolbuffers/protobuf/issues/10619
installRemoteModule_version=3.24.2
fi
fi
;;
Expand Down

0 comments on commit ee1b129

Please sign in to comment.