New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new CO track_frames
and replace/deprecate track_samples
#13168
Comments
This are not all COs, that use frames. |
That's right but it doesn't matter because |
Currently, a few features such as cue, loops but also waveform rendering relies on the track sample count to function properly. They all assume tracks being in stereo. This is misleading as the samples count isn't providing a useful information as there is no way to know if the count has been normalised to stereo (e.g for mono or stem tracks)
In order to clean this up, we should:
track_frames
which provide the true frame count of the loaded track (sample count/number of channel)track_samples
to use the frame count instead. Persistence (e.g for cues and loop) will continue usingframecount x 2
to maintain backward compatibility)track_samples
in the code and in the manual in case user have built up integration with it. In the meantime, its value should be kept toframecount x 2
in order to ensure backward compatibility (e.g with custom community mapping)Note that currently, there is no
track_channels
to provide the channel count (and allow computing the true sample counts) but it looks like that isn't something that can be of use just yet, so we should refrain from proactively adding this CO. if it gets required in the future, it should be trivial to add.The text was updated successfully, but these errors were encountered: