Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Customization of ssh-privatekey and ssh-publickey for SSHKeyPair #92

Open
jkupferer opened this issue Dec 19, 2023 · 3 comments
Open

Comments

@jkupferer
Copy link

Is your feature request related to a problem? Please describe.

For compatibility with using deploy keys with ArgoCD it is necessary to be able to generate SSH keypair secrets with data sshPrivateKey rather than the default ssh-privatekey.

Other use cases may also require the SSH public and private keys to use custom data names.

Describe the solution you'd like

Perhaps add spec.sshPrivateKeyDataName and spec.sshPublicKeyDataName to SSHKeyPair custom resource to allow overriding the defaults?

Describe alternatives you've considered

I've been unable to come up with a reasonable alternative.

Additional context

n/a

@jkupferer
Copy link
Author

jkupferer commented Dec 19, 2023

#91 addresses similar needs. Perhaps this feature request should be folded into that one?

@martin-helmich
Copy link
Member

Perhaps add spec.sshPrivateKeyDataName and spec.sshPublicKeyDataName to SSHKeyPair custom resource to allow overriding the defaults?

That sounds reasonable! Currently, our capacities to work on this project are limited, so PRs are always welcome.

@mrchypark
Copy link

@jkupferer I am currently attempting to work on #91. I would like to address this issue together. Can we discuss the design aspect in #91?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants