Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mask not available help from input mirrorz.json #66

Open
ZenithalHourlyRate opened this issue Mar 13, 2023 · 0 comments
Open

feat: mask not available help from input mirrorz.json #66

ZenithalHourlyRate opened this issue Mar 13, 2023 · 0 comments

Comments

@ZenithalHourlyRate
Copy link
Collaborator

Currently, the list in https://mirrors.help always displays all mirror items.

However, once we do not have data for one help doc, accessing that help doc would result in an exception. We should mask them in the list.

xtom.help just overrides the json https://github.com/xtomcom/xtom.help/blob/master/override/routes.json

TUNA mirror-web instead, masks them by deleting items after statically rendering them in https://github.com/tuna/mirror-web/blob/cdc12cd622e43206b7b7b32be3b112db9d44bf32/static/js/help.es6#L55
ZenithalHourlyRate added a commit that referenced this issue Mar 28, 2023
@ZenithalHourlyRate
feat(layout): hide nav bar from query
5d88d4a 
Ref to #66

Mirror sites may use this to hide the nav bar when redirecting users
from their home page.
@ZenithalHourlyRate ZenithalHourlyRate mentioned this issue Mar 28, 2023
Open
ZenithalHourlyRate added a commit that referenced this issue Mar 28, 2023
@ZenithalHourlyRate
feat(layout): hide nav bar from query
efad7a0 
Ref to #66

Mirror sites may use this to hide the nav bar when redirecting users
from their home page.
ZenithalHourlyRate added a commit that referenced this issue Mar 29, 2023
@ZenithalHourlyRate
feat(layout): hide nav bar from query
151baab 
Ref to #66

Mirror sites may use this to hide the nav bar when redirecting users
from their home page.
ZenithalHourlyRate added a commit that referenced this issue Mar 29, 2023
@ZenithalHourlyRate
feat(layout): hide nav bar from query
9e2bf79 
Ref to #66

Mirror sites may use this to hide the nav bar when redirecting users
from their home page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZenithalHourlyRate