Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JG fails with jQuery 4 #396

Open
jefftucker1952 opened this issue Nov 16, 2024 · 3 comments
Open

JG fails with jQuery 4 #396

jefftucker1952 opened this issue Nov 16, 2024 · 3 comments

Comments

@jefftucker1952
Copy link

This falls into the category of "future trouble." jQuery 4.0.0 is now in its second beta release. JustifiedGallery fails with this version of jQuery, with the following console error:

jquery.justifiedGallery.min.js:8 Uncaught TypeError: l.type is not a function
    at HTMLDivElement.<anonymous> (jquery.justifiedGallery.min.js:8:18834)
    at Function.each (jquery4.js:2:2876)
    at T.fn.init.each (jquery4.js:2:1386)
    at l.fn.justifiedGallery (jquery.justifiedGallery.min.js:8:18702)
    at index4.html:60:17
(anonymous) @ jquery.justifiedGallery.min.js:8
each @ jquery4.js:2
each @ jquery4.js:2
l.fn.justifiedGallery @ jquery.justifiedGallery.min.js:8
@miromannino
Copy link
Owner

Hello Jeff, I have already have a branch with a version 4.0 without jquery.

Just need to make extra sure is stable as thousands are using JG.

If you are able to test this branch it would be awesome

@jefftucker1952
Copy link
Author

I'd be happy to test it, if I had even a clue about how to download the JS file. Remember, you're not talking to a "GitHub person." To me, GitHub is just a confusing maze. ;)

@kostenickj
Copy link

I can test it out, which branch is it? Really want to use this but dont want to add jquery to my site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants