Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors back #42

Open
manishtpatel opened this issue Apr 10, 2012 · 2 comments
Open

Report errors back #42

manishtpatel opened this issue Apr 10, 2012 · 2 comments

Comments

@manishtpatel
Copy link

ses.call('SendEmail', send_args, function(err, result) {
console.log(result);
});

Consider above code, when SendEmail request is sent to aws, aws either responds with error or success. But aws-lib does not report error as err, it just returns result back.

Right now everyone i thik parse the result to figure out what happened. But correct way to find result type is using http response code.

We need to use http error code, if code is >= 400 or <600, it should return it as err.

Link to api for easy access
http://docs.amazonwebservices.com/ses/latest/APIReference/API_SendRawEmail.html

@ndabas
Copy link

ndabas commented Aug 19, 2012

I agree - the HTTP status code should be used to determine error status. The issue is here.

With SES, the error is returned in the result as Error instead of Errors.

@willwhite
Copy link
Contributor

See #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants