-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove autostart #2374
Comments
@cah-briangantzler doesn't it make server running in |
No, that is the |
In the future I would propose that the |
Out of curiosity, I tried |
It seems pretty unlikely that a significant number of people are using For the sake of simplicity I think removing it is a reasonable idea. |
Our codebase is quite old and uses |
I am currently struggling with this as well.. even with a modern test setup (post 3.0) mirage server is still auto running somehow... causing Update: My ENV setup was wrong if (environment === 'test') {
...
ENV['ember-cli-mirage'] = {
enabled: true,
}; maybe this config was a relic from an older time pre-rfc-232/236? but having this in ENV forces auto-run to happen despite this guard statement maybe there needs to be some new (or restored 👀 ) documentation describing this behavior and how to properly migrate away from it? |
Is anyone actually using the
autostart
environment variable? I would assume this starts the server in the tests instead of usingsetupMirage
. I can find it documented and usingsetupMirage
is the preferred way to start the server.Are we able to remove it since it is not documented? Would be nice to remove an
instance-initializer
if its not being used.References:
https://github.com/miragejs/ember-cli-mirage/blob/master/addon/instance-initializers/ember-cli-mirage-autostart.js
The text was updated successfully, but these errors were encountered: