Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses old version of ember-get-config so ember-dependency-lint fails #2239

Open
BryanCrotaz opened this issue Nov 7, 2021 · 9 comments
Open

Comments

@BryanCrotaz
Copy link

This addon uses ember-get-config 0.3.0. The latest is 0.5.0

@rahulk94
Copy link
Contributor

I've raised #2242 which bumps the minimum version of ember-get-config to ^0.3.0. Whilst this doesn't bump to latest as you have requested it does resolve some deprecation warnings. Unsure if this is what you were after or the reasoning behind going to latest is but ya thought I would mention here just incase its relevant.

@BryanCrotaz
Copy link
Author

Why not bump to latest?

Because it's a zero major version you can't make it play nice with resolutions, so dependency lint fails the test run because it's an old version that literally no one else is using

@rahulk94
Copy link
Contributor

rahulk94 commented Nov 18, 2021

I've gone for the safest/most un-intrusive fix in my PR just to clear deprecations (which can then go out in a service pack here).

I agree with you that this project should at some point be updated to use 0.5.0 though to fix dep linting but from a quick look, 0.5.0 drops Ember < 3.4 support. No clue if this matters for ember-cli-mirage as I don't see its support matrix anywhere.

#2240 probably needs resolution before there can be any real changes on this project now though since it doesn't look very maintained atm.

@cah-brian-gantzler
Copy link
Collaborator

Ember try only does 3.20. Should probably add a few more backwards and see where it breaks

@cah-brian-gantzler
Copy link
Collaborator

cah-brian-gantzler commented Nov 20, 2021

Updated ember try in a test and ember-cli-mirage requires 3.4+

Sorry, the tests require 3.4+ the addon may not. (The error when running under 2.18 was something to do with aria-labels).
This is the issue when upgrading ember-cli-addon-docs, the requirement for the tests are greater than that of the addon.

@cah-brian-gantzler
Copy link
Collaborator

Likewise the tests dont run under 3.28 but it looks like the addon docs portion of the dummy app not the actual tests themselves :(

@cah-brian-gantzler
Copy link
Collaborator

The package.json has been updated

"ember-get-config": "0.2.4 - 0.5.0",

And a release 2.3.0 has been published.

Please let us know if this does not help with the problem

@jrjohnson
Copy link
Contributor

get-config now has a 1.0 release!! Bumping to that should place much nicer across the addon ecosystem as everything won't have to stay as in sync anymore.

@SergeAstapov
Copy link
Collaborator

@jrjohnson it's on radar! we'll upgrade ember-get-config to v1 in ember-cli-mirage v3 release as ember-get-config@1 dropped support for Node.js 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants