-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uses old version of ember-get-config so ember-dependency-lint fails #2239
Comments
I've raised #2242 which bumps the minimum version of ember-get-config to |
Why not bump to latest? Because it's a zero major version you can't make it play nice with resolutions, so dependency lint fails the test run because it's an old version that literally no one else is using |
I've gone for the safest/most un-intrusive fix in my PR just to clear deprecations (which can then go out in a service pack here). I agree with you that this project should at some point be updated to use 0.5.0 though to fix dep linting but from a quick look, 0.5.0 drops Ember < 3.4 support. No clue if this matters for ember-cli-mirage as I don't see its support matrix anywhere. #2240 probably needs resolution before there can be any real changes on this project now though since it doesn't look very maintained atm. |
Ember try only does 3.20. Should probably add a few more backwards and see where it breaks |
Updated ember try in a test and ember-cli-mirage requires 3.4+ Sorry, the tests require 3.4+ the addon may not. (The error when running under 2.18 was something to do with aria-labels). |
Likewise the tests dont run under 3.28 but it looks like the addon docs portion of the dummy app not the actual tests themselves :( |
The package.json has been updated
And a release 2.3.0 has been published. Please let us know if this does not help with the problem |
get-config now has a 1.0 release!! Bumping to that should place much nicer across the addon ecosystem as everything won't have to stay as in sync anymore. |
@jrjohnson it's on radar! we'll upgrade |
This addon uses ember-get-config 0.3.0. The latest is 0.5.0
The text was updated successfully, but these errors were encountered: