Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API to query if files are included in build #2167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bendemboski
Copy link
Collaborator

Implement a public API (using the environment config) for addons to determine if mirage's files are included in the build, so they can decide whether to include any mirage-dependent files.

Fixes #2166

Implement a public API (using the environment config) for addons to determine if mirage's files are included in the build, so they can decide whether to include any mirage-dependent files.

Fixes miragejs#2166
@bendemboski
Copy link
Collaborator Author

Outstanding issues:

  • I have not tested this manually yet -- I will soon, but wanted to get this open for discussion/feedback ASAP
  • There are no automated tests for this functionality, although it looks like there are no automated tests for the code inclusion/exclusion at all so maybe that's okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public API for addons to determine if mirage files are included in the buld
2 participants