Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon for prometheus in openshift 3.7 #50

Open
durandom opened this issue Nov 24, 2017 · 3 comments · May be fixed by #51
Open

addon for prometheus in openshift 3.7 #50

durandom opened this issue Nov 24, 2017 · 3 comments · May be fixed by #51
Labels
kind/task priority/major

Comments

@durandom
Copy link
Contributor

the current addon works for 3.6 - but for 3.7 we also need the node exporter and alert manager
durandom added a commit to durandom/minishift-addons that referenced this issue Nov 24, 2017
@durandom
Issue minishift#50 addon for prometheus in openshift 3.7
bbb13e0 
prometheus for openshift 3.7
@durandom durandom linked a pull request Nov 24, 2017 that will close this issue
Open
durandom added a commit to durandom/minishift-addons that referenced this issue Nov 26, 2017
@durandom
Issue minishift#50 addon for prometheus in openshift 3.7
173b51c 
prometheus for openshift 3.7
durandom added a commit to durandom/minishift-addons that referenced this issue Nov 26, 2017
@durandom
Issue minishift#50 addon for prometheus in openshift 3.7
2f9d839 
prometheus for openshift 3.7
@LalatenduMohanty
Copy link
Member

@durandom @jorgemoralespou Is there no way we can make the existing add-on to work for both 3.6 and 3.7?

@durandom
Copy link
Contributor Author

I cant think of a way how. 3.6 needs a different application template. Unless there is a way to conditionally run oc commands, I dont see how

@coolbrg
Copy link
Contributor

coolbrg commented Dec 27, 2017 •
edited
Loading

Unless there is a way to conditionally run oc commands

No such way as of now in add-on.
I think we have two options at the moment:

  1. Keep separate addon folder for both version (Current PR behavior)
  2. One addon folder
    • We need one prometheus.addon and another prometheus.3.6.addon.example
    • Document how to use 3.6 version add-on

WDYT @LalatenduMohanty ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task priority/major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

addon for prometheus in openshift 3.7 durandom/minishift-addons
3 participants
@durandom @coolbrg @LalatenduMohanty