Healthcheck should be declared in Dockerfile

[Crocmagnon]

In my opinion, the healthcheck should be declared in the Dockerfile so that it benefits by default.

Users can disable it anyway if they want, see: https://docs.docker.com/compose/compose-file/compose-file-v2/#healthcheck

[fguillot]

It was initially in the Dockerfile and I moved it to the docker-compose here: 20ec435

The main reason is you could use the same Docker image without the web server enabled. It's an optional feature.

In Kubernetes, the HEALTHCHECK instruction is always ignored because readiness and liveness probes are the preferred way.

[Crocmagnon]

It was initially in the Dockerfile and I moved it to the docker-compose

Yes, I saw this commit, it’s the reason behind this discussion 😊

The main reason is you could use the same Docker image without the web server enabled. It's an optional feature.

I feel like it’s easier to disable an undesired healthcheck especially if you run the image with a non-default command than to find the good one to setup.

[zebala]

BTW, the start_period in the health check is only supported in compose version 3.4, while the current version is 3.3.