Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org-modern blocks subtree movement/refiling #128

Closed
japhir opened this issue May 9, 2023 · 6 comments
Closed

Org-modern blocks subtree movement/refiling #128

japhir opened this issue May 9, 2023 · 6 comments

Comments

@japhir
Copy link

japhir commented May 9, 2023

Since a while I get some issues with org-modern!

Here are the steps to recreate what I did: use alphapapa's with-emacs

with-emacs.sh -i org-modern

create a new org file, e.g. ~/Downloads/test-org-modern.org, write:

* test
** heading
*** inheritance
* new

M-x org-modern-mode

This gives me the following warning:

Warning (comp): org-modern.el:807:27: Warning: the function ‘pos-bol’ is not known to be defined. Disable showing Disable logging

Now to get the real issues:

  1. Put cursor on heading test and use M-S-left arrow or right arrow to try to move an org-heading down a level, including its children
    -> Only the current heading moves.
  2. Navigate cursor to heading new, C-c C-w to refile it, type test.
    -> The heading gets copied to test, but remains its own heading as well

Turn off org-modern-mode and try again to get the desired behaviour.

org-modern.el has this in it:

;; Created: 2022
;; Version: 0.9
;; Package-Version: 20230422.634
;; Package-Commit: e0a1a00490acc3bbbf199e433c9ef60e03f9d416
@japhir japhir changed the title Org-modern blocks subtree movement Org-modern blocks subtree movement/refiling May 9, 2023
@minad
Copy link
Owner

minad commented May 9, 2023

The pos-bol error is caused since you miss the Compat dependency. Ensure that you update all packages. Maybe you use Straight? Straight doesn't respect version contraints, see radian-software/straight.el#1083. I cannot reproduce the demote issue in my setup, but that's expected since the demote problem is most likely caused by the missing pos-bol function.

@minad minad closed this as completed May 9, 2023
@japhir
Copy link
Author

japhir commented May 9, 2023

Hey thanks for getting back to me.

I do have compat installed however! I've used use-package with :ensure t to install org-modern, which should take care of dependencies. I had also just done a M-x list-packages (... wait for refresh) U y.

Status: Installed in ‘compat-29.1.4.1/’.
Version: 29.1.4.1

In my list of packages it says it's been installed as a dependency.

Required by: with-editor-20230212.2214, transient-20230508.1924, org-modern-20230422.634, moody-20230212.2015, magit-section-20230428.1518, magit-20230502.1321, keycast-20230212.2016, git-commit-20230313.1724

But to prevent it being an issue with my own setup, I included the MWE that uses with-emacs.sh to show that it also occurs when I only install org-modern (and its dependencies) (which just uses (package-install X)).

Cheers

@minad
Copy link
Owner

minad commented May 9, 2023

I don't know what the issue is, but I cannot reproduce it with emacs -Q and org-modern and compat. Maybe you use a very outdated commit of Emacs 29?

@japhir
Copy link
Author

japhir commented May 9, 2023

I'm on Emacs 29.0.50, which I've built quite a while ago because compilation takes so long. This might be the issue?

@japhir
Copy link
Author

japhir commented May 10, 2023

You were right, updating to Emacs 30.0.50 has resolved this issue! Thanks :)

@minad
Copy link
Owner

minad commented May 11, 2023

Please make sure that you update Emacs more regularly if you use the master branch to prevent such issues in the future. The master branch cannot be considered stable since it is early in its life cycle. Otherwise I recommend that you use Emacs 29 from the emacs-29 branch which is stable. Personally I compile Emacs from the emacs-29 branch myself until Emacs 30 stabilizes a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants