Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always loading react-hot-loader production AppContainer #159

Open
boba-keyost opened this issue Oct 16, 2017 · 3 comments
Open

Always loading react-hot-loader production AppContainer #159

boba-keyost opened this issue Oct 16, 2017 · 3 comments
Labels

Comments

@boba-keyost
Copy link

If loader ignores changes in node_modules packages then it uses default require function to load 'react-hot-loader' module. And this module doesn't have 'module.hot' property so it always loads production version.

@milankinen
Copy link
Owner

Hello! Sorry but I couldn't get the problem yet. Could you rephrase the issue?

@boba-keyost
Copy link
Author

Hm, ok.
If you're using multiple bundles with reloadable application and non reloadable vendor libs(e.g. react etc.) you should add react-hot-loader package to reloadable bundle.

@milankinen
Copy link
Owner

milankinen commented Oct 24, 2017

Correct, vendor libs are not hot-reloaded because the assumption is that developer does not "live-modify" their content. Of course new libraries can be added and existing ones can be updated but in that case, you need to restart Browserify. And there is no multi-bundle support yet, see #146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants