Entity discovery not working with bun after upgrade to 6.2.2

[co-sic]

Hey, i think that #5464 broke folder-based entity discovery with bun. I know bun is not officially supported, so i'm not opening an issue. I don't have a reproduction yet and will just downgrade for now, but if you want to look into it, i can provide one tomorrow.

Error:

[info] MikroORM version: 6.2.2
[discovery] ORM entity discovery started, using TsMorphMetadataProvider
[discovery] - processing 17 files
[discovery] - ignoring file index.ts
[discovery] - ignoring file index.ts
[discovery] - ignoring file ScopedPermissionType.ts
[discovery] - ignoring file Language.ts
[discovery] - ignoring file PermissionType.ts
[discovery] - ignoring file PermissionScope.ts
[discovery] - processing entity Role (~/src/entities/Role.ts)
119 |             this.initSourceFiles();
120 |         }
121 |         const source = this.sources.find(s => s.getFilePath().endsWith(core_1.Utils.stripRelativePath(tsPath)));
122 |         if (!source && validate) {
123 |             throw new core_1.MetadataError(`Source file '${tsPath}' not found. Check your 'entitiesTs' option and verify you have 'compilerOptions.declaration' enabled in your 'tsconfig.json'. If you are using webpack, see https://bit.ly/35pPDNn`);
124 |         }
^
MetadataError: Source file './src/entities/Role.ts' not found. Check your 'entitiesTs' option and verify you have 'compilerOptions.declaration' enabled in your 'tsconfig.json'. If you are using webpack, see https://bit.ly/35pPDNn
at getSourceFile (~/node_modules/@mikro-orm/reflection/TsMorphMetadataProvider.js:124:15)
at readTypeFromSource (~/node_modules/@mikro-orm/reflection/TsMorphMetadataProvider.js:96:110)
at initPropertyType (~/node_modules/@mikro-orm/reflection/TsMorphMetadataProvider.js:71:23)
at initProperties (~/node_modules/@mikro-orm/reflection/TsMorphMetadataProvider.js:32:38)
at loadEntityMetadata (~/node_modules/@mikro-orm/reflection/TsMorphMetadataProvider.js:16:33)
at discoverEntity (~/node_modules/@mikro-orm/core/metadata/MetadataDiscovery.js:373:99)
at ~/node_modules/@mikro-orm/core/metadata/MetadataDiscovery.js:278:9
at asyncFunctionResume (native:1:1)
at promiseReactionJobWithoutPromiseUnwrapAsyncContext (native:1:1)
at promiseReactionJob (native:1:1)
at processTicksAndRejections (native:1:1)

[B4nan]

I surely don't want people to downgrade, things that worked should remain working, so repro welcome :] Maybe it even won't be bun specific, let's see.

cc @xmajzel

[xmajzel]

I'm not sure why it shouldn't work, looks like it might be a specific case for TsMorphMetadataProvider, despite the tests for that provider working.

Certainly reproduction would be fine, what I was wondering what is the name of the file compared to the name of the class within the file (@co-sic)?

When fixing #5464, omitting setting Global metadata caused the same error as provided by @co-sic in TsMorphMetadataProvider.test.ts test file (See comment in code bellow).

• So I think the problem could theoretically be what key the metadata is set under for this entity in the global metadata.

MetadataDiscovery.getSchema:

 if (entity instanceof EntitySchema) {
      if (filepath) {
        // Try comment out following line. Then run TsMorphMetadataProvider.test.ts tests to see error.
        MetadataStorage.getMetadata(entity.meta.className, filepath);
      }

      return entity;
    }

cc @Ruby184

[co-sic]

I will provide a reproduction tomorrow :)

[co-sic]

@xmajzel here is the reproduction: https://github.com/co-sic/bun-playground/tree/mikro-orm . You should get the error there if you follow the README to start. If you downgrade to 6.2.1 and run again, it will work. Let me know if you need anything else

[B4nan]

Oh, nice, would you PR that now, or should I?

(I want to release a new stable nowish)

[Ruby184]

You can use the code above :) I will PR later just perf improvement for detection so it will always run only once :)

[co-sic]

Nice, thanks for the quick fix for this! :) @B4nan @Ruby184

[co-sic]

Short update for anybody else stumbling on this: I noticed it was not working on js files, only on ts files. In my docker setup i still had a build step and run the .js files in production. But since bun itself says there is no significant downside to directly running ts files in production (see here: https://bun.sh/docs/runtime/typescript), i changed it and everything works now.

[SnowMarble]

@co-sic I think we have to account for this. There could be teams or people who use js for legacy systems or change their runtime to Bun.