-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIBP excluded entries are still included when scanning #59
Comments
Hi, thanks for the detailed report. Excluded passwords are not checked, it is just the progress bar that counts all passwords. Not sure if it's worth fixing, it would just complicate the logic for the progress bar, but I'll give it a thought. |
This provokes a lot of questions :) Sorry for them in advance.
Kind of strange logic going on here, but you know the code, not me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Scenario
Conclusion
It seems the Excluded feature is only considered when checking the entire password database (via Tools -> HIBP Offline Check... -> Check All Passwords), and not through the right-click context menu.
I can see the use for doing HIBP checks for entries which are marked Excluded, but not as a default; a user expects an excluded entry to truly be excluded.
Recommended change
In the right-click context menu, make a new option called "Check (forced)", which will check selected entries regardless of their Excluded status. However, "Check" should exclude entries as described above.
The text was updated successfully, but these errors were encountered: