-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] [MGT-CHAT] Cannot easily set permission scopes #3120
Comments
Vite does weird things with bundling in dev mode, and in fact just doesn't work when the ACS ui library components are imported, so that's really fun. So, I'd make sure that you're testing that scenario using a static build and serving the result. The suggestion to move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It should be easy to make changes to the enabled features and then derive the appropriate permission scopes. Consider for instance, changes like this...
That would need to run before the exported constant
allChatScopes
. Unfortunately, no matter how we set the dependencies to load (even using import module promises), we found inconsistent results. I should mention the implementation was also using Vite, so maybe there is something around packaging. By inconsistent results, I mean most users had MgtPersonCardConfig running first and it worked as expected, but not 100% of the time. A few users never worked.I propose changing allChatScopes, allChatListScopes, etc. to functions, then it becomes really easy to control when they are computed.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
100% of all users get the same behavior 100% of the time.
Screenshots
NA
Environment (please complete the following information):
Additional context
I am a MSFT FTE and can be reached on Teams at pelasne.
The text was updated successfully, but these errors were encountered: