Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: GaijinNetwork.WarThunder.CDK version 2024.07.24 #190452

Closed
wants to merge 2 commits into from
Closed

New package: GaijinNetwork.WarThunder.CDK version 2024.07.24 #190452

wants to merge 2 commits into from

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Nov 11, 2024 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Additional information

It seems this package depends on HUGE (from 19.6GB minimum, to 115.8GB top quality) game contents of War Thunder.

Game contents are too large for me. Appreciate if other contributors & volunteers can investigate it further. 🙏🏼

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@Dragon1573 Dragon1573 marked this pull request as draft November 11, 2024 15:39
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Nov 11, 2024
@wingetbot
Copy link
Collaborator

Url validation error

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 11, 2024
@Dragon1573
Copy link
Contributor Author

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

This problem is already mentioned in #190448. It will be resolved by #190449.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 11, 2024
@Dragon1573 Dragon1573 marked this pull request as ready for review November 12, 2024 09:25
@Dragon1573
Copy link
Contributor Author

Dependency issue resolved. Another attempt can be triggered manually ❤️

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978334960
2024-11-11 07:59:11.270 [CLI ] Package hash verification failed. SHA256 in manifest [58793f14b277bd13935e37a1b4c7771b341e96579fe5e164b351db498225ed2d] does not match download [60ce5ea054da2b0e952d3cb0be5297e13bc9a0954fb8e19e64b42a7d6b46c007]

Automated error analysis suggests -1978334960 may mean Failed to install package dependencies.

(Automated response - build 897.)

@Dragon1573
Copy link
Contributor Author

/AzurePipelines run

stephengillie
stephengillie requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic Validation ended with:

Installation failed with exit code -1978334960
2024-11-11 07:59:11.270 [CLI ] Package hash verification failed. SHA256 in manifest [58793f14b277bd13935e37a1b4c7771b341e96579fe5e164b351db498225ed2d] does not match download [60ce5ea054da2b0e952d3cb0be5297e13bc9a0954fb8e19e64b42a7d6b46c007]

Automated error analysis suggests -1978334960 may mean Failed to install package dependencies.

(Automated response - build 897.)

manifests/g/GaijinNetwork/WarThunder/CDK/2024.07.24/GaijinNetwork.WarThunder.CDK.installer.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. labels Nov 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 15, 2024
@Dragon1573 @stephengillie
Apply suggestions from code review
fd71d45 
- Correction of installer hash value

Co-authored-by: Stephen Gillie <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application Changes-Requested Changes Requested Moderator-Approved One of the Moderators has reviewed and approved this PR labels Nov 16, 2024
@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Nov 16, 2024
@wingetbot
Copy link
Collaborator

Url validation error

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 16, 2024
@Dragon1573
Copy link
Contributor Author

Caution

It seems the installer file changes frequently. We're unable to pass the validation pipeline. 😞

@Dragon1573 Dragon1573 closed this Nov 16, 2024
@Dragon1573 Dragon1573 deleted the issues/189983 branch November 16, 2024 16:00
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie requested changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees

@Dragon1573 Dragon1573

@stephengillie stephengillie

Labels
Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: GaijinNetwork.WarThunder.CDK
4 participants
@Dragon1573 @wingetbot @stephengillie @ItzLevvie