showIncludesExcludes doesn't hide query details

[tkj-seasony]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.89.0
• OS Version: Windows 10.0.19045

Steps to Reproduce:

Create a keybinding to workbench.action.findInFiles with the showIncludesExcludes argument set to false.

    {
        "key": "ctrl+shift+f",
        "command": "workbench.action.findInFiles",
        "args": {            
            "showIncludesExcludes": false,
            "useExcludeSettingsAndIgnoreFiles": false,            
        }
    },

The search sidepanel appears but if the includes and excludes fields were shown from a prior search they are still visible.
The same happens even though the includes and excludes are cleared:

    {
        "key": "ctrl+shift+f",
        "command": "workbench.action.findInFiles",
        "args": {            
            "showIncludesExcludes": false,
            "useExcludeSettingsAndIgnoreFiles": false,       
            "filesToInclude": "",     
            "filesToExclude": "",     
        }
    },

[andreamah]

Hmm, that isn't currently an option in findInFiles. But it can be added. You can see the existing fields here:

vscode/src/vs/workbench/contrib/search/browser/searchActionsFind.ts

Lines 39 to 51 in 220eb8e

	export interface IFindInFilesArgs {
	query?: string;
	replace?: string;
	preserveCase?: boolean;
	triggerSearch?: boolean;
	filesToInclude?: string;
	filesToExclude?: string;
	isRegex?: boolean;
	isCaseSensitive?: boolean;
	matchWholeWord?: boolean;
	useExcludeSettingsAndIgnoreFiles?: boolean;
	onlyOpenEditors?: boolean;
	}

[VSCodeTriageBot]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!