Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks run task and Configure task commands infinte load or no-op on vscode web #212047

Closed
mahmoudsalah1993 opened this issue May 5, 2024 · 3 comments · Fixed by #212163
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues
Milestone

Comments

@mahmoudsalah1993
Copy link
Contributor

mahmoudsalah1993 commented May 5, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.89.0
  • OS Version: Any, vscode web

Steps to Reproduce:

  1. Open a repository on github, and hit . to open vscode.dev
  2. Open command palette and run Tasks: Run Task or Tasks: Configure Tasks

Expected:

Both commands show list of tasks pertraining to the repository or the option to create tasks.json etc

Actual:

Run tasks command simply is no-op not showing the quickpick.
Configure task keeps infintely loading.

image

@meganrogge
Copy link
Contributor

thanks for the issue, do you know if this happened in earlier versions of vscode.dev?

@meganrogge meganrogge added info-needed Issue requires more information from poster tasks Task system issues labels May 6, 2024
@meganrogge
Copy link
Contributor

I see

Warning: npm tasks are unavailable in the current environment.

Warning: shell tasks are unavailable in the current environment.

in the output channel. Unsure if these worked before

@mahmoudsalah1993
Copy link
Contributor Author

We've had this issue reported for several months in our internal version of web-based vscode. The issue seemed to stem that both commands awaited for the onDidRegisterAllSupportedExecutions event to be fired, which in a web environment this never gets fired, shell executions aren't supported for example.

Changing the condition to fire if any execution type is registered #212163 seems to resolve the issue and no issues seem to be visible user flow wise. The warnings generally show only when some non-supported executions are available, but don't cause issues for the dialog or show up as options for users.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels May 7, 2024
@meganrogge meganrogge added this to the May 2024 milestone May 7, 2024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants