With canvas, should the line be continuous? #158984
Assignees
Labels
bug
Issue identified by VS Code Team member as probable bug
insiders-released
Patch has been released in VS Code Insiders
terminal-rendering
upstream
Issue identified as 'upstream' component related (exists outside of VS Code)
upstream-issue-fixed
The underlying upstream issue has been fixed
upstream-issue-linked
This is an upstream issue that has been reported upstream
verified
Verification succeeded
Milestone
Comments
|
I didn't bother adding this to the canvas renderer as it's the fallback which is primarily for iPad atm, nothing stopping it from working there too though. Should really consolidate the rendering code for webgl and canvas as they mostly do the same thing when drawing the actual characters. xtermjs/xterm.js#4062 |
Tyriar
added
feature-request
Tyriar
added a commit
that referenced
this issue
Oct 6, 2022
- Bump copyright year xtermjs/xterm.js#4176 - Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170 - Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169 - Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168 - Create new event with emitter object to simplify code xtermjs/xterm.js#4166 - Define all events and emitters consistently xtermjs/xterm.js#4165 - Inline dirty row service into input handler xtermjs/xterm.js#4163 - Move w objects to $ prefix variables xtermjs/xterm.js#4162 Fixes #158984 Fixes #158874
Merged
Tyriar
added
the
upstream-issue-fixed
VSCodeTriageBot
added
unreleased
Tyriar
added
bug
|
The wavy underline looks off with gpu enabled (first example in the attached screenshot). With the canvas setting, it's not rendered at all. |
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this issue
Nov 25, 2022
- Bump copyright year xtermjs/xterm.js#4176 - Share texture atlas cache code between webgl and canvas renderers xtermjs/xterm.js#4170 - Add willReadFrequently to canvas renderer too xtermjs/xterm.js#4169 - Ensure texture atlas comparison uses rgba not object xtermjs/xterm.js#4168 - Create new event with emitter object to simplify code xtermjs/xterm.js#4166 - Define all events and emitters consistently xtermjs/xterm.js#4165 - Inline dirty row service into input handler xtermjs/xterm.js#4163 - Move w objects to $ prefix variables xtermjs/xterm.js#4162 Fixes microsoft#158984 Fixes microsoft#158874
|
The look of curly was going to be revisited in xtermjs/xterm.js#4064 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Testing #158827
using canvas render.
Should the line be continuous even though it overlaps the characters?
vs "on":
I'm talking about characters like
pandq.The text was updated successfully, but these errors were encountered: