-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH still available in container even I disable forwardWSLServices
#9897
Comments
|
Are you trying to isolate the container? The extension also forwards the X11 display, the Wayland display, the |
Yes. I try to use Dev Container to prevent been hacked from Seems like we have UI issue. It was unclear to me what WSL is in the context of Dev Container plugin (I am using Linux). Maybe we can rename option to explain that they do not protect Linux/Mac machine. Also, can we add options to disable forwarding |
My understanding is that Docker containers are not a security boundary. So even with all these features disabled, you won't have a "secure" setup. There might be ways to harden the container I'm not familiar with. |
SSH inside container can connect to GitHub even if I disable
forwardWSLServices
andgitCredentialHelperConfigLocation
.There are no keys in
~/.ssh
(inside container) and nohelper
ingit config -l
My settings:
VSCode Version: 1.89.1
Local OS Version: Fedora 40
Remote OS Version: ubuntu:24.04
Remote Extension/Connection Type: Containers
Logs:
Steps to Reproduce:
forwardWSLServices
, andgitCredentialHelperConfigLocation
ssh -T [email protected]
The text was updated successfully, but these errors were encountered: