Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines falsely shown as removed in diff editor #361

Closed
chrmarti opened this issue Sep 4, 2018 · 1 comment
Closed

Lines falsely shown as removed in diff editor #361

chrmarti opened this issue Sep 4, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Sep 4, 2018

Issue Type: Bug

image

The const options and onDidChangeSelection lines are not actually removed:

image

The PR: microsoft/vscode-extension-samples#89

Extension version: 0.0.22
VS Code version: Code - Insiders 1.27.0-insider (7b9afc4196bda60b0facdf62cfc02815509b23d6, 2018-09-03T09:07:33.052Z)
OS version: Darwin x64 17.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.53GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron
Screen Reader no
VM 0%
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Sep 4, 2018
@roblourens
Copy link
Member

Seeing a similar issue here, maybe the same thing: https://github.com/Microsoft/vscode/pull/57957/files

image

In extHostSearch.test.ts, the catch line is not actually removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants