Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the inlineCompletion example #879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix the inlineCompletion example #879

wants to merge 1 commit into from
+6 −89

Conversation

tardyp
Copy link

@tardyp tardyp commented Jun 21, 2023

Now that the extension is GA, the code sample does not need the enableAPIProposal config.
the API has been simplified a bit since the proposal, so the code has been simplified as well

Fixes #867

Fixes microsoft/vscode#150732

@tardyp
Copy link
Author

tardyp commented Jun 21, 2023

@microsoft-github-policy-service agree

@tardyp
Copy link
Author

tardyp commented Jun 21, 2023

@hediet

@tardyp
fix the inlineCompletion example
743d9e5 
Now that the extension is GA, the code sample does not need the proposed API
the API has been simplified a bit since the proposal, so the code has been simplified as well
justin-fiedler
justin-fiedler approved these changes Jun 30, 2023
View reviewed changes
Copy link

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks!

yaokangyou
yaokangyou reviewed Nov 16, 2023
View reviewed changes
Copy link

@yaokangyou yaokangyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

121212

yaokangyou
yaokangyou suggested changes Nov 16, 2023
View reviewed changes
Copy link

@yaokangyou yaokangyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

121212

@Cooky420 Cooky420 mentioned this pull request Nov 21, 2023
Closed
This was referenced Sep 4, 2024
Open
Open
@rcjsuen
Copy link

rcjsuen commented Sep 4, 2024

@tardyp Thank you so much for this workaround. The sample is working for me now!

@hediet Any chance we can get this reviewed and merged?

@wangzelin007
Copy link
Member

Works for me. Thanks!

@heaversm
Copy link

This doesn't work in my custom extension - when it is packaged and installed as a .vsix I still get the errors. See this discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaokangyou yaokangyou yaokangyou requested changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@hediet hediet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inline-completions example is not work Problem running inlineCompletions Sample
7 participants
@tardyp @rcjsuen @wangzelin007 @heaversm @justin-fiedler @yaokangyou @hediet