Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip empty client in MGC #5388

Open
live1206 opened this issue Dec 17, 2024 · 1 comment · May be fixed by #5218
Open

Skip empty client in MGC #5388

live1206 opened this issue Dec 17, 2024 · 1 comment · May be fixed by #5218
Assignees
@live1206
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@live1206
Copy link
Contributor

live1206 commented Dec 17, 2024 •
edited
Loading

There is a common pattern in mgmt TypeSpec to define an interface containing only 1 list_operations operation.
Since it is duplicated with existing API in Azure.ResourceManager.
.NET SDK will skip it during generation, and this interface becomes empty.

Right now, MGC still generates empty client without methods.
Should we skip the empty clients in MGC?
@live1206 live1206 added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Dec 17, 2024
@live1206 live1206 linked a pull request Dec 17, 2024 that will close this issue
Open
@live1206
Copy link
Contributor Author

Offline confirmed with @JoshLove-msft, we should skip the empty client and the accessor method in MGC.

@live1206 live1206 self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@live1206 live1206

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip empty client generation live1206/typespec
1 participant
@live1206