Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error List pane resize separator #147

Closed
Binaryify opened this issue Jun 8, 2022 · 12 comments · Fixed by #148
Closed

Error List pane resize separator #147

Binaryify opened this issue Jun 8, 2022 · 12 comments · Fixed by #148

Comments

@Binaryify
Copy link
Collaborator

Describe the bug
It is difficult to see where to place the cursor for resizing the Error List pane when a file is open in the most recent update.

Screenshots

Repeat Binaryify/OneDark-Pro#740

It should have a split line
In vscode, it look like this
image

@ryanbuening
Copy link

Adding some clarification...this would occur on any pane docked there, not just the error list.

@ketttY
Copy link
Contributor

ketttY commented Jun 22, 2022

Hi @Binaryify, sorry for the delayed response, got some high-priority tasks that need to be addressed. I have tried reproducing this issue with One Dark Pro, One Dark Pro Darker, One Dark Pro Flat and One Dark Pro Mix, but none of them produced result like the one in the gif. I am wondering can you let me know which version of One Dark Pro you converted for the official extension? Thank you!

@Binaryify
Copy link
Collaborator Author

@ryanbuening

@Binaryify
Copy link
Collaborator Author

@ketttY I used this json file which generate from the vscode's generate from current theme command
https://gist.github.com/Binaryify/81fd565c1ac851b9cf55e852c77caa01

@Binaryify
Copy link
Collaborator Author

Binaryify commented Jun 23, 2022

also my vs's version is 17.2.3

@Binaryify
Copy link
Collaborator Author

and it look like this in my vs
image

@ryanbuening
Copy link

I'm on 17.2.5

OneDark-Pro (Binaryify) theme:

image

Default Dark theme:

image

@ketttY ketttY linked a pull request Jun 23, 2022 that will close this issue
@ketttY
Copy link
Contributor

ketttY commented Jun 23, 2022

@Binaryify and @ryanbuening, thank you both for the clarification! I have created #148 to address this issue. Feel free to take a look and see if that meets your expectations! Thank you!

@ryanbuening
Copy link

That looks good to me. 👍

@Binaryify
Copy link
Collaborator Author

thank for the fast response, I just re-generate a new vsix and it look great

@ryanbuening
Copy link

ryanbuening commented Jun 24, 2022

@ketttY, could a similar thing be done (border) for the Tabs pane when tabs are placed on the left?...

image

@ketttY
Copy link
Contributor

ketttY commented Jun 27, 2022

@ryanbuening, after checking, it looks like VS does not have a border token for that area, so for now the theme converter can't add a border there. Apologize for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants