b #18350
Closed
b #18350
+192,829
−131,041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More descriptive warnings are triggered when custom pixel shader compilation fails. If D3DCompileFromFile fails and the compiler generates an error message- the message is converted to a wstring and is sent as a parameter when calling p.warningCallback. Changes were made to resources.resw and TermControl.cpp to accommodate this. ## Validation Steps Performed I tested the following errors that may be encountered while developing a custom pixel shader: 1. Compile time errors 2. File not found error 3. Path not found error 4. Access denied error Fixes microsoft#17435 TAEF tests passed: Summary: Total=294, Passed=294, Failed=0, Blocked=0, Not Run=0, Skipped=0
This specs out a lot of plans for snippets. We've already got these in the sxnui as "tasks", but we can do so very much more. This spec is a few years old now, but it's time for it to get promoted out of my draft branch. References: * microsoft#1595 * microsoft#7039 * microsoft#3121 * microsoft#10436 * microsoft#12927 * microsoft#12857 * microsoft#5790 * microsoft#15845 --------- Co-authored-by: Dustin L. Howett <[email protected]>
This now covers all major Console APIs. In the future we could add tests that cover VT sequences as well.
The initial contents of a texture are undefined. That's not good. Now they are. That's good.
Adds `$profile:experimental.rainbowSuggestions`, which makes the suggestion text all RGB. This sparks joy.
First, this adds `GraphemeTableGen` which * parses `ucd.nounihan.grouped.xml` * computes the cluster break property for each codepoint * computes the East Asian Width property for each codepoint * compresses everything into a 4-stage trie * computes a LUT of cluster break rules between 2 codepoints * and serializes everything to C++ tables and helper functions Next, this adds `GraphemeTestTableGen` which * parses `GraphemeBreakTest.txt` * splits each test into graphemes and break opportunities * and serializes everything to a C++ table for use as unit tests `CodepointWidthDetector.cpp` was rewritten from scratch to * use an iterator struct (`GraphemeState`) to maintain state * accumulate codepoints until a break opportunity arises * accumulate the total width of a grapheme * support 3 different measurement modes: Grapheme clusters, `wcswidth`-style, and a mode identical to the old conhost With this in place the following changes were made: * `ROW::WriteHelper::_replaceTextUnicode` now uses the new grapheme cluster text iterators * The same function was modified to join new text with existing contents of the current cell if they join to form a cluster * Otherwise, a ton of places were modified to funnel the selection of the measurement mode over from WT's settings to ConPTY This is part of microsoft#1472 ## Validation Steps Performed * So many tests ✅ * https://github.com/apparebit/demicode works fantastic ✅ * UTF8-torture-test.txt works fantastic ✅
…t#16848) ### `OSC 9001; CmdNotFound; <missingCmd>` Adds support for custom OSC "command not found" sequence `OSC 9001; CmdNotFound; <missingCmd>`. Upon receiving the "CmdNotFound" variant with the missing command payload, we send the missing command up to the Quick Fix menu and add it in as `winget install <missingCmd>`. ### Quick Fix UI The Quick Fix UI is a new UI surface that lives in the gutter (left padding) of your terminal. The button appears if quick fixes are available. When clicked, a list of suggestions appears in a flyout. If there is not enough space in the gutter, the button will be presented in a collapsed version that expands to a normal size upon hovering over it. The Quick Fix UI was implemented similar to the context menu. The UI itself lives in TermControl, but it can be populated by other layers (i.e. TermApp layer). Quick Fix suggestions are also automatically loaded into the Suggestions UI. If a quick fix is available and a screen reader is attached, we dispatch an announcement that quick fixes are available to notify the user that that's the case. Spec: microsoft#17005 microsoft#16599 ### Follow-ups - microsoft#17377: Add a key binding for quick fix - microsoft#17378: Use winget to search for packages using `missingCmd` --------- Co-authored-by: Dustin L. Howett <[email protected]> Co-authored-by: Dustin L. Howett <[email protected]>
## Summary of the Pull Request This PR introduces basic support for the Sixel graphics protocol in conhost, limited to the GDI renderer. ## References and Relevant Issues This is a first step towards supporting Sixel graphics in Windows Terminal (microsoft#448), but that will first require us to have some form of ConPTY passthrough (microsoft#1173). ## Detailed Description of the Pull Request / Additional comments There are three main parts to the architecture: * The `SixelParser` class takes care of parsing the incoming Sixel `DCS` sequence. * The resulting image content is stored in the text buffer in a series of `ImageSlice` objects, which represent per-row image content. * The renderer then takes care of painting those image slices for each affected row. The parser is designed to support multiple conformance levels so we can one day provide strict compatibility with the original DEC hardware. But for now the default behavior is intended to work with more modern Sixel applications. This is essentially the equivalent of a VT340 with 256 colors, so it should still work reasonably well as a VT340 emulator too. ## Validation Steps Performed Thanks to the work of @hackerb9, who has done extensive testing on a real VT340, we now have a fairly good understanding of how the original Sixel hardware terminals worked, and I've tried to make sure that our implementation matches that behavior as closely as possible. I've also done some testing with modern Sixel libraries like notcurses and jexer, but those typically rely on the terminal implementing certain proprietary Xterm query sequences which I haven't included in this PR. --------- Co-authored-by: Dustin L. Howett <[email protected]>
Adds support for a new `settings` object in the theme settings. This includes a single property, `theme`. This allows users to set a different theme from the app's requested theme, if they so choose. Closes microsoft#9231 --------- Co-authored-by: Mike Griese <[email protected]>
Assuming we do have a bug somewhere, initializing these members will allow us to consistently reproduce the bug, whereas without the initialization the member values will all be random and so they may result in random behavior which would make finding the root cause more difficult (or at least less consistent).
This also updates the localization pipeline to check in translations for the PDPs. Right now, the primary source for PDPs is the Terminal.Internal repository. They are submitted from there, and pulled back in as though they were destined for the internal repo. We rename them on disk prior to loc check-in to pretend they live in this repo. Once I submit a change request to the Touchdown team to update the paths in their backend, I will follow up with another pull request that updates the remaining build steps to account for that.
Hi wanted to make an attempt at [12857](microsoft#12857). This still needs work but I think the initial version is ready to be reviewed. ## Summary of the Pull Request Mostly copied from: microsoft/terminal@6f5b9fb...1cde67a - Save to disk - If command line is empty use selection - Show toast - No UI. Trying out the different options now. ## PR Checklist - [ ] Closes microsoft#12857 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary) --------- Co-authored-by: Mike Griese <[email protected]>
This removes all of the 2D iteration machinery. Imagine the text buffer as a `Cell[w][h]` grid. Clearly, this is identical to a `Cell[w*h]` array, which shows that copying between overlapping ranges only needs either forward or backward copying, and not left/right/top/down. With `WalkDir` removed, `WalkInBounds` can be rewritten with basic arithmetic which allows `pos` to be an exclusive end coordinate.
We'd previously subtract one underline-height from the curly line offset, even though we already had subtracted its complete height. Additionally, the pixel shader received some fine tuning: * Shrink the stroke width so that the anti-aliasing can be seen all the way up to the horizontal edges of the bounding box. * Add a phase shift to break apart the symmetry of the curve. Closes microsoft#17482 Co-authored-by: Carlos Zamora <[email protected]>
This PR add supports for two query sequences that are used to determine the pixel size of a character cell: * `CSI 16 t` reports the pixel size of a character cell directly. * `CSI 14 t` reports the pixel size of the text area, and when divided by the character size of the text area, you can get the character cell size indirectly (this method predates the introduction of `CSI 16 t`). These queries are used by Sixel applications that want to fit an image within specific text boundaries, so need to know how many cells would be covered by a particular pixel size, or vice versa. Our implementation of Sixel uses a virtual cell size that is always 10x20 (in order to emulate the VT340 more accurately), so these queries shouldn't really be needed, but some applications will fail to work without them. ## References and Relevant Issues Sixel support was added to conhost in PR microsoft#17421. ## Validation Steps Performed I've added some unit tests to verify that these queries are producing the expected responses, and I've manually tested on [XtermDOOM] (which uses `CSI 16 t`), and the [Notcurses] library (which uses `CSI 14 t`). [XtermDOOM]: https://gitlab.com/AutumnMeowMeow/xtermdoom [Notcurses]: https://github.com/dankamongmen/notcurses ## PR Checklist - [x] Tests added/passed
…icrosoft#17507) This allows us to remove the dependency on the `Terminal.Internal` repository. I have also added some parameters to the build pipeline to ease testing.
- Remove the `deprecated` flag for the `keybindings` array now that we have re-added that - Update `userDefaults` to use the correct ID for the `Copy` command
This adds a snippets pane, which can be a static pane with all your snippets (`sendInput` actions) in it. (See microsoft#17329) This pane has a treeview with these actions in it, that we can filter with a textbox at the top. Play buttons next to entries make it quick to run the command you found. Bound in the default actions with ```json { "command": { "action": "splitPane", "type": "snippets" }, "id": "Terminal.OpenSnippetsPane", "name": { "key": "SnippetsPaneCommandName" } }, ``` re: microsoft#1595 ---- TODO, from 06-04 bug bash * [x] Snippets pane doesn't display some "no snippets found" text if there aren't any yet * [x] open snippets pane; find a "send input"; click the play button on it; input is sent to active pane; begin typing * [x] I can open an infinite amount of suggestions panes * ~I'm closing this as by-design for now at least. Nothing stopping anyone from opening infinite of any kind of pane.~ * ~This would require kind of a lot of refactoring in this PR to mark a kind of pane as being a singleton or singleton-per-tab~ * Okay everyone hates infinite suggestions panes, so I got rid of that * [x] Ctrl+Shift+W should still work in the snippets pane even if focus isn't in textbox * [ ] open snippets pane; click on text box; press TAB key; * [ ] If you press TAB again, I have no idea where focus went * [x] some previews don't work. Like `^c` (`"input": "\u0003"`) * [x] nested items just give you a bit of extra space for no reason and it looks a little awkward * [x] UI Suggestion: add padding on the right side * [ ] [Accessibility] Narrator says "Clear buffer; Suggestions found 132" when you open the snippets pane - Note: this is probably Narrator reading out the command palette (since that's where I opened it from) - We should probably expect something like "Snippets", then (assuming focus is thrown into text box) "Type to filter snippets" or something like that
…ft#17514) We have to run in an older OneBranch Windows container image due to compiler bugs. This change prevents us from having to wait for the container image to download for build legs that _aren't_ using the compiler.
* Modified `Generate-PseudoLocalizations.ps1` to find the .xml files. (As opposed to .resw for the other translations.) * Added support for the new format by adding new XPath expressions, and stripping comments/attributes as needed. * Fixed `PreserveWhitespace` during XML loading. * Fixed compliance with PowerShell's strict mode. ## Validation Steps Performed Ran it locally and compared the results. ✅
This fixes some more issues not properly covered by microsoft#17526: * Fixed `_locComment_text` comments being effectively ignored. * Fixed line splitting of comments (CRLF vs LF). * Fixed BOM suppression. * Fixed support for having multiple `{Locked=...}` comments.
…oft#17451)" This reverts commit e9212e4.
As it turns out, you cannot use `<uap17:UpdateWhileInUse>` (or any other newer namespace) unless you declare a corresponding `MaxVersionTested` in your package manifest. It does not appear that there's a reason for this, it just is. `MaxVersionTested` is not to be confused with the `maxversiontested`, which is something else entirely, but I updated it for safe measure. Since `maxversiontested` is not a "max", but rather a list of tested versions, it gets appended to the end of the list. Closes microsoft#18119
There were two bugs: * Ever since the conhost v1 -> v2 rewrite the `readDataDirect.cpp` implementation incorrectly passed `false` as the wait flag. The unintentional mistake is obvious in hindsight as the check for `CONSOLE_STATUS_WAIT` makes no sense in this case. * The ConPTY integration into `InputBuffer` was done incorrectly, as it would unconditionally wake up the readers/waiters without checking if the buffer is now actually non-empty. Closes microsoft#15859 ## Validation Steps Performed Test code: ```cpp #include <Windows.h> #include <stdio.h> int main() { HANDLE in = GetStdHandle(STD_INPUT_HANDLE); INPUT_RECORD buf[128]; DWORD read; SetConsoleMode( in, ENABLE_PROCESSED_INPUT | ENABLE_VIRTUAL_TERMINAL_INPUT ); for (int i = 0; ReadConsoleInputW(in, buf, 128, &read); ++i) { printf("%d read=%lu\n", i, read); } return 0; } ``` Run it under Windows Terminal and type any input. >50% of all inputs will result in `read=0`. This is fixed after this PR.
## Summary of the Pull Request Adds customization for the New Tab Menu to the settings UI. - Settings Model changes: - The Settings UI generally works by creating a copy of the entire settings model objects on which we apply the changes to. Turns out, we completely left the NewTabMenu out of that process. So I went ahead and implemented it. - `FolderEntry` - `FolderEntry` exposes `Entries()` (used by the new tab menu to figure out what to actually render) and `RawEntries()` (the actual JSON data deserialized into settings model objects). I went ahead and exposed `RawEntries()` since we'll need to apply changes to it to then serialize. - View Model: - `NewTabMenuViewModel` is the main view model that interacts with the page. It maintains the current view of items and applies changes to the settings model. - `NewTabMenuEntryViewModel` and all of the other `_EntryViewModel` classes are wrappers for the settings model NTM entries. - `FolderTreeViewEntry` encapsulates `FolderEntryViewModel`. It allows us to construct a `TreeView` of just folders. - View changes and additions: - Added FontIconGlyph to the SettingContainer - Added a New Tab Menu item to the navigation view - Adding entries: a stack of SettingContainers is used here. We use the new `FontIconGlyph` to make this look nice! - Reordering entries: drag and drop is supported! This might not work in admin mode though, and we can't drag and drop into folders. Buttons were added to make this keyboard accessible. - To move entries into a folder, a button was added which then displays a TreeView of all folders. - Multiple entries can be moved to a folder or deleted at once! - Breadcrumbs are used for folders - When a folder is entered, additional controls are displayed to customize that folder. ## Verification - ✅ a11y pass - ✅ keyboard accessible - scenarios: - ✅ add entries (except actions) - ✅ changes propagated to settings model (aka "saving works") - ✅ reorder entries - ✅ move entries to an existing folder - ✅ delete multiple entries - ✅ delete individual entries - ✅ display entries (including actions) ## Follow-ups - [ ] add support for adding and editing action entries - [ ] when we discard changes or save, it would be cool if we could stay on the same page - [ ] allow customizing the folder entry _before_ adding it (current workaround is to add it, then edit it) - [ ] improve UI for setting icon (reuse UI from microsoft#17965)
This upgrades to [check-spelling v0.0.24]. A number of GitHub APIs are being turned off shortly, so we need to upgrade or various uncertain outcomes will occur. There are some minor bugs that I'm aware of and which I've fixed since this release (including a couple I discovered while preparing this PR). There's a new accessibility forbidden pattern: #### Should be `cannot` (or `can't`) See https://www.grammarly.com/blog/cannot-or-can-not/ > Don't use `can not` when you mean `cannot`. The only time you're likely to see `can not` written as separate words is when the word `can` happens to precede some other phrase that happens to start with `not`. > `Can't` is a contraction of `cannot`, and it's best suited for informal writing. > In formal writing and where contractions are frowned upon, use `cannot`. > It is possible to write `can not`, but you generally find it only as part of some other construction, such as `not only . . . but also.` - if you encounter such a case, add a pattern for that case to patterns.txt. ``` \b[Cc]an not\b ``` [check-spelling v0.0.24]: https://github.com/check-spelling/check-spelling/releases/tag/v0.0.24 Signed-off-by: Josh Soref <[email protected]>
…8277) It seems I forgot to add this in microsoft#16916.
## Summary of the Pull Request Added open current directory action. ## References and Relevant Issues Need to set this: https://learn.microsoft.com/en-us/windows/terminal/tutorials/new-tab-same-directory ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed - Ensure shell has been configured - Run "Open current working directory" action in command palette - File explorer opens the correct directory ## PR Checklist - [x] Closes microsoft#12859 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary)
…#17690) Most of the logic is taken from the original PR (microsoft#15417) and adapted to work with the palette. ## References and Relevant Issues [microsoft#12382](microsoft#12382)
This increases the console IO buffer size to retain at least 128KiB as this matches the default buffer size of `cat`. This avoids allocator churn due to constantly freeing and reallocating buffers. In the future this should ideally use a better suited, cheap allocator. Closes microsoft#18286
* Previously we would mark all gc=Cf (Control, format) codepoints as zero-width, but that ignores that the majority of them are also GCB=CN (Control = does not join), which meant we ended up with zero-width grapheme clusters. Those cannot exist under a terminal. So, this PR makes all gc=Cf, GCB=CN codepoints zero-width, but also treats them as Extender codepoints, which mirrors `wcswidth`. * This PR also updates the tables to Unicode 16.0. * Finally, there's a minor code cleanup of the generator. Closes microsoft#18267 ## Validation Steps Performed * Unit tests ✅ * Thai does not have random gaps anymore due to ZWSP ✅
…oft#17909) Left, Top, Right and Bottom paddings can be set separetely in `Appearance`. I tried to make it as close as possible to one of the suggestions in microsoft#9127. I hope it doesn't look that bad. Closes microsoft#9127
If we colored a tab, then switched to another tab, there's a bug that the unselected tab loses its color. This was introduced in PR microsoft#18109. This PR fixes that by actually applying the selected color to the tab (whoops). Additionally, I removed setting the "TabViewItemHeaderCloseButtonBackground" resource because it looked weird (see comment in PR). Closes microsoft#18226
…t#17870) ## Summary of the Pull Request Adds some pre-existing settings ($profile.foreground, $profile.background, $profile.selectionBackground, $profile.cursorColor) to the settings UI. This was accomplished by introducing a new control: NullableColorPicker. This control allows the user to pick a color from the color scheme, set the color to null, and select a color from an advanced color picker. Improves the UI for the Profile.Icon setting by adding an "Icon Type" combo box. This allows the user to pick from multiple options: - None: sets the icon to "none" which is interpreted as no icon - Built-in Icon: presents a combo box that enumerates the Segoe MDL 2 assets - Emoji: presents a text box with a hint to open the emoji picker - File: presents a text box to input the path of the image to use Additionally, the rendered icon is displayed in the setting container. If "none", "none" is presented to the user (localized). ## References and Relevant Issues microsoft#10000 ## Detailed Description of the Pull Request / Additional comments - NullableColorPicker control - includes a built-in NullColorButton to set the current value to null - includes a "More colors..." button to display an advanced color picker - uses data templates on data templates (data templates squared?) to convert the current color scheme into a grid of color chips - color chips display a checkmark (similar to Windows settings personalization). This automatically updates its color to stay compliant with color contrast. - color chips are added to a list so we can (un)check them when a new color is selected - SettingsContainer changes - Forked `ExpanderSettingContainerStyle` to allow for a custom preview template. This way, we can display the current value in the expander and we're not just limited to text. - changed type of `CurrentValue` property from `String` to `IInspectable` - added `CurrentValueTemplate` property to control how to display the current value - Miscellaneous: - Added a few converters (`BooleanToVisibility`, `ColorToString`, `ColorToBrush`) - Added `NameWithHexCode` to `ColorTableEntry` to expose a color as `Red #RRGGBB` (used for tooltips and a11y) - Added `ForegroundPreview` (and equivalent for other colors) to AppearanceViewModel to deduce the color that will be used ## Validation Steps Performed - [X] a11y pass (NVDA, keyboard) - [X] set the color to one of the color chips - [X] set the color to null - [X] set the color to a value from the integrated color picker - [X] control updates properly when a new color scheme is selected - [X] control updates properly when a color scheme has multiple colors of the same value ## Follow-ups - [A11y] Screen readers don't read expander's preview text - Add Tab Color to settings UI - Update CursorColor preview to display #FFFFFF as "invert" - Use Leonard's font picker UI, with the Segoe icon picker, so that you can filter the list
As before, a minor refactor: * I started off by removing the Monarch/Peasant with the goal of moving it into and deduplicating its functionality with `WindowEmperor`. * Since I needed a replacement for the Monarch (= ensures that there's a single instance), I wrote single-instance code with a NT mutex and by yeeting data across processes with `WM_COPYDATA`. * This resulted in severe threading issues, because it now started up way faster. The more I tried to solve them the deeper I had to dig, because you can't just put a mutex around `CascadiaSettings`. I then tried to seeif WinUI can run multiple windows on a single thread and, as it turns out, it can. So, I removed the multi- from the window threading. * At this point I had dig about 1 mile deep and brought no ladder. So, to finish it up, I had to clean up the entire eventing system around `WindowEmperor`, cleaned up all the coroutines, and cleaned up all the callbacks. Closes microsoft#16183 Closes microsoft#16221 Closes microsoft#16487 Closes microsoft#16532 Closes microsoft#16733 Closes microsoft#16755 Closes microsoft#17015 Closes microsoft#17360 Closes microsoft#17420 Closes microsoft#17457 Closes microsoft#17799 Closes microsoft#17976 Closes microsoft#18057 Closes microsoft#18084 Closes microsoft#18169 Closes microsoft#18176 Closes microsoft#18191 ## Validation Steps Performed * It does not crash ✅ * New/close tab ✅ * New/close window ✅ * Move tabs between windows ✅ * Split tab into new window ✅ * Persist windows on exit / restore startup ✅
## Summary of the Pull Request Adds the Profile.BellSound setting to the Settings UI under the Profile > Advanced page. - View changes: - The setting is exposed via an expander placed near the Profile.BellStyle setting. - Added a button to be able to preview the added sound - Added a browse button that opens a file picker - Added a delete button to be able to delete each sound entry - View model changes: - `CurrentBellSounds` keeps track of the bell sounds added and exposed via the UI. - `BellSoundViewModel` wraps each sound. This allows us to listen (and propagate) changes to the registered sounds. - `BellSoundPreview` provides a written preview of the current bell sound to display in the expander microsoft#10000
CodeQL is raising errors when building Visual Studio since we have a dependency on Windows Terminal for our integrated terminal. The issue raised is not applicable to this case and therefore requires a suppression comment to ignore the raised error.
Forgetti di spaghetti in microsoft#18215. Closes microsoft#18324 ## Validation Steps Performed * Launch through the start menu * Explicitly minimize * Then... * Launch through the start menu again ✅ * Launch via wtd.exe in Win+R ✅ * Launch via wtd.exe in another Terminal ✅ * Launch via handoff ✅
Signed-off-by: jorgeferreir2k21 <[email protected]>
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)distcheck These words are not needed and should be removedabcd ABCDEFGHIJ abcdefghijk ABCDEFGHIJKLMNOPQRS ABCDEFGHIJKLMNOPQRST ABCDEFGHIJKLMNOPQRSTUVWXY allocs appium Argb asan autocrlf backported bytebuffer cac CLE codenav codepath commandline COMMITID componentization constness dealloc deserializers DISPATCHNOTIFY DTest entrypoints EVENTID FINDUP fuzzer hlocal hstring IInput Interner keyscan Munged numlock offboarded pids positionals Productize pseudoterminal remoting renamer roadmap ruleset SELECTALL somefile Stringable tearoff TODOs touchpad TREX Unregistering USERDATA vectorize viewports wslTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:jorgeferreir2k21/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/12448622390/attempts/1'
Errors (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. ✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later. If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 If the flagged items are 🤯 false positivesIf items relate to a ...
|
jorgeferreir2k21
changed the base branch from
main
to
dev/migrie/f/name-windows
jorgeferreir2k21
changed the base branch from
dev/migrie/f/name-windows
to
dev/lhecker/openconsole-async-start
|
@jorgeferreir2k21 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
PR Checklist