Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undercurl error in zellij in neovim #18312

Closed
Daydreamer-riri opened this issue Dec 12, 2024 · 5 comments
Closed

Undercurl error in zellij in neovim #18312

Daydreamer-riri opened this issue Dec 12, 2024 · 5 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@Daydreamer-riri
Copy link

Sorry to bring it up here, but I'm really not sure what the problem is.

Image
Image

Image

in wezterm

As shown in the figure. I am not sure which aspect of the problem (neovim, windows terminal, zellij, I think it is possible), in short, it is the neovim in zellij in wsl.

Because of the same situation, wezterm is normal. So I'm opening an issue here.

Basic information

zellij --version: zellij 0.41.2

stty size:62 245

uname -av or ver(Windows): wsl2 unbuntu 2404

I also opened an Issue in zellij's repo: zellij-org/zellij#3866

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 12, 2024
@lhecker
Copy link
Member

lhecker commented Dec 12, 2024

I believe neovim disables curly underlines if it thinks the terminal can't handle it. Can you try launching neovim with TERM=kitty neovim or similar? You can read more about it here: https://neovim.io/doc/user/tui.html#%24TERM

@Daydreamer-riri
Copy link
Author

Oh, you are right. The default TERM is xterm-256color, It works well under normal circumstances. The undercurl is lost only in nvim in zellij. When I change it to something else, like tmux, vte, undercurl works. Is that normal? I am still lacking in this knowledge.

Image

@Daydreamer-riri
Copy link
Author

Hi @lhecker, has there been any progress on this issue? It seems that on my x86 computer, setting TERM to vte-256colors in zellij perfectly resolves the error. However, for some reason, my WSL Ubuntu on my ARM computer does not have the terminfo for vte-256colors. Additionally, I noticed a significant difference in the number of terminfo files in the /usr/share/terminfo directory between the two machines.

So the current situation is that my ARM computer doesn't have a good solution. What should I do? If you need any information, please feel free to let me know! I will do my best to cooperate.

@lhecker
Copy link
Member

lhecker commented Dec 20, 2024

When I change it to something else, like tmux, vte, undercurl works. Is that normal? I am still lacking in this knowledge.

Some terminal applications like neovim perform feature detection: They try to guess what your terminal is safely capable of and then will only send VT sequences that they think are supported. The main way those applications figure out what the terminal is, is via the TERM environment variable. I'm not entirely sure whether it's zellij or neovim which guesses wrong in this case, but I think it may be the latter.

Hi @lhecker, has there been any progress on this issue?

I apologize. I was already on my way out to the winter holidays. I'll be closing this issue since it's not an issue with Windows Terminal itself. We can continue talking about it here though. (I may be slow to respond over the next few weeks, as I'll be on vacation and need the time to work on some other stuff.)

However, for some reason, my WSL Ubuntu on my ARM computer does not have the terminfo for vte-256colors. Additionally, I noticed a significant difference in the number of terminfo files in the /usr/share/terminfo directory between the two machines.

So the current situation is that my ARM computer doesn't have a good solution. What should I do? If you need any information, please feel free to let me know! I will do my best to cooperate.

Are you sure your two computers are using the exact same WSL image? Maybe one uses Ubuntu 22 and the other uses Ubuntu 24 or something? First, I'd make sure they use the same WSL image, and then I'd update all packages (sudo apt update; sudo apt full-upgrade if it's Debian/Ubuntu IIRC).

@lhecker lhecker closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
@Daydreamer-riri
Copy link
Author

Thank you very much for your reply! Your response was very detailed and clear. I have temporarily resolved my issue by copying the vte-256color terminfo file. I will report this behavior to Neovim to find the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants