Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terminal Chat AI] Allow company wide disabling this feature #16401

Closed
Tracked by #15000
htcfreek opened this issue Nov 30, 2023 · 7 comments
Closed
Tracked by #15000

[Terminal Chat AI] Allow company wide disabling this feature #16401

htcfreek opened this issue Nov 30, 2023 · 7 comments
Labels
Area-Chat All things LLM or "AI" Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@htcfreek
Copy link

Description of the new feature/enhancement

Some companies don't allow the usage of AI features or software that has AI feature for privacy reasons.

Please implement a way to centrally force disable this feature.

Proposed technical implementation details (optional)

This can be a policy or HKLM registry value/setting that admins can use to easily disabled this feature for all users.

This setting should work for portable, store and manually installed versions and on all chanels.
@htcfreek htcfreek added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 30, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 30, 2023
@zadjii-msft
Copy link
Member

Perfectly reasonable ask. I'll link it up to #15000, thanks!

My understanding of GPO is that it can be used to set a reg key, so we can easily query that regardless of what distribution method used.

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Chat All things LLM or "AI" and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Dec 5, 2023
@zadjii-msft zadjii-msft mentioned this issue Dec 5, 2023
Open
@htcfreek
Copy link
Author

htcfreek commented Dec 6, 2023 •
edited
Loading

@zadjii-msft
I suggest you to implement a common class where you do the registry reading and that return standardized values like we did in PowerToys (https://github.com/microsoft/PowerToys/blob/main/src/common/utils/gpo.h).

Either you evaluate the Policy ones at application startup or every time the settings window and chat window gets opened.

The default expected behavior of policies is that computer scope has a higher priority than user scoope. And that you are able to set it either in user or in computer scope.

I think the category in the ADMX file should be Microsoft\Windows Components\Windows Terminal. The Registry key can be Software\Policies\Microsoft\Windows Terminal or Software\Policies\Microsoft\Windows\Terminal.

@g0t4
Copy link

g0t4 commented Dec 7, 2023

Given the current setup process requires custom azure resources, isn't that sufficient for an approval process at least short term?

@htcfreek
Copy link
Author

htcfreek commented Dec 7, 2023

Given the current setup process requires custom azure resources, isn't that sufficient for an approval process at least short term?

I thought everyone is able to create such an required account including private persons. Is that wrong? Don't know about this.

If I require a special company account/license/configuration then it should be enough for short term.

@carlos-zamora carlos-zamora removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 13, 2023
@carlos-zamora carlos-zamora added this to the Backlog milestone Dec 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Dec 13, 2023
@htcfreek
Copy link
Author

htcfreek commented Oct 8, 2024 •
edited
Loading

@DHowett , @lhecker
This is similar to #17964.

@ilhacker, i mistakenly mentioned you.

@htcfreek htcfreek mentioned this issue Oct 13, 2024
Closed
5 tasks
@PankajBhojwani PankajBhojwani mentioned this issue Oct 22, 2024
Merged
4 tasks
DHowett pushed a commit that referenced this issue Oct 29, 2024
@PankajBhojwani @htcfreek
Allow enterprises to disable Terminal Chat or specific LMs (#18095)
438621f 
## Summary of the Pull Request
Adds registry keys to allow enterprises to disable Terminal Chat or only
enable certain LMs

Notes:
- If the policy is not set at all, all LM providers are allowed
- If the policy is set, we look at the provided allow list to determine
which LMs (if any) should be allowed
- Only the allowed LMs show up in the AI Settings page to allow for
configuration
- If no LMs are allowed, the Terminal Chat action is not shown in the
new tab dropdown nor the command palette and existing keybindings to
open Terminal Chat are not handled
- Regardless of the policy, any keybindings/modifications to a user's
toggle terminal chat action are preserved

## Validation Steps Performed
Toggling the policy/updating the allow list updates the settings page,
dropdown and command palette appropriately

## PR Checklist
- [x] Closes #16401

Co-authored-by: Heiko <[email protected]>
@zadjii-msft
Copy link
Member

@PankajBhojwani Double check me - this was resolved by #18095, but since that PR wasn't into main, GitHub just didn't auto-close the issue, yea?

@PankajBhojwani
Copy link
Contributor

This was resolved by #18095 yep, not entirely sure why the bot didn't close it but I'll close it manually now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Chat All things LLM or "AI" Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@g0t4 @carlos-zamora @zadjii-msft @PankajBhojwani @htcfreek