Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Improve and enable integration tests for MongoDB connector #9410

Open
dmytrostruk opened this issue Oct 23, 2024 · 0 comments
Open

.Net: Improve and enable integration tests for MongoDB connector #9410

dmytrostruk opened this issue Oct 23, 2024 · 0 comments
Assignees
@dmytrostruk
Labels
.NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@dmytrostruk
Copy link
Member

Currently, we use mongodb/mongodb-atlas-local Docker image to perform integration tests in our CI pipeline for MongoDB connector. It appeared that sometimes vector search doesn't return any results, so the tests are failing, and PR merge is blocked:
Image

Since this error is transient, it's not clear what is the root cause. The scope of this task is to investigate the root cause, provide a fix and enable integration tests for MongoDB connector so they will be executed during PR merge.
@dmytrostruk dmytrostruk self-assigned this Oct 23, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Oct 23, 2024
@dmytrostruk dmytrostruk mentioned this issue Oct 23, 2024
Merged
4 tasks
@markwallace-microsoft markwallace-microsoft added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2024
@dmytrostruk @markwallace-microsoft
.Net: Temporarily disable MongoDB integration tests (#9411)
18aa431 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Currently, we use `mongodb/mongodb-atlas-local` Docker image to perform
integration tests in our CI pipeline for MongoDB connector. It appeared
that sometimes vector search doesn't return any results, so the tests
are failing, and PR merge is blocked:

![Image](https://github.com/user-attachments/assets/3e1126dc-e219-46a0-89aa-6c5e898678bb)

This PR temporarily disables these integration tests until the root
cause will be found. Related issue:
#9410.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Mark Wallace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmytrostruk dmytrostruk

Labels
.NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmytrostruk @markwallace-microsoft