Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a /status or /health for Retina 10093 #1047

Open
mereta opened this issue Nov 20, 2024 · 3 comments
Open

Add a /status or /health for Retina 10093 #1047

mereta opened this issue Nov 20, 2024 · 3 comments

Comments

@mereta
Copy link
Contributor

mereta commented Nov 20, 2024

Describe the bug
The readinessProbe currently uses localhost:10093/metrics to figure out if retina is ready. The metrics returned is dependent on scale, and can timeout if the data amount is high. Add a status/health path that returns fixed amount of data.

Hubble & legcay.

@rbtr
Copy link
Collaborator

rbtr commented Nov 20, 2024

since we already have ctrl runtime this is an easy way to add these: https://sigs.k8s.io/controller-runtime/pkg/healthz

@nddq
Copy link
Contributor

nddq commented Nov 20, 2024

@rbtr would the ctrl runtime's health and readiness reflect Retina's health and readiness as a whole? Since there could be other components that is not related to the controllers that are erroring out and ctrl runtime wouldn't know about

@rbtr
Copy link
Collaborator

rbtr commented Nov 20, 2024

it's modular, ctrlruntime healthz is a framework that we plug our own details in to

@anubhabMajumdar anubhabMajumdar added this to the 1.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants