Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user guide since fetching latest version is failed #1020

Open
root-hbx opened this issue Nov 18, 2024 · 5 comments
Open

Fix user guide since fetching latest version is failed #1020

root-hbx opened this issue Nov 18, 2024 · 5 comments

Comments

@root-hbx
Copy link

Describe the bug

Latest VERSION is not up to date.

According to Release in this repo, v0.10.1 is the latest version.

But the fetched latest in CLI on local machine is still v0.0.18

To Reproduce

I was following guide in README.md, everything works well until: metrics-quick-install

The problem is Latest VERSION is not up to date.

❯ VERSION=$( curl -sL https://api.github.com/repos/microsoft/retina/releases/latest | jq -r .name)echo $VERSION
v0.0.18

Obviously, it didn't automatically fetch the latest version.

Expected behavior

I bypass this issue with "hard-code":

❯ VERSION=v0.10.1
  ~                                                                                                                                                           ⎈ kind-skypilot  01:27:57
❯ helm upgrade --install retina oci://ghcr.io/microsoft/retina/charts/retina \
    --version $VERSION \
    --set image.tag=$VERSION \
    --set operator.tag=$VERSION \
    --set logLevel=info \
    --set enabledPlugin_linux=dropreason\\,packetforward\\,linuxutil\\,dns
Release "retina" does not exist. Installing it now.
Pulled: ghcr.io/microsoft/retina/charts/retina:v0.10.1
Digest: sha256:428fdcfc197b275cd41cf094b5bed4077b2eecad002a6ed31868e388ec7c42b3
NAME: retina
LAST DEPLOYED: Mon Nov 18 01:27:59 2024
NAMESPACE: default
STATUS: deployed
REVISION: 1
NOTES:
1. Installing retina service using helm: helm install retina ./deploy/legacy/manifests/controller/helm/retina/ --namespace kube-system --dependency-update
2. Cleaning up/uninstalling/deleting retina and dependencies related:
  helm uninstall retina -n kube-system

Now it works.

Platform (please complete the following information):

  • OS: Apple M2 Pro
  • Kubernetes Version: 1.29.4
  • Host: KIND
  • Retina Version:
@root-hbx
Copy link
Author

Detailed logs when following current Metrics Quick Install Guide

❯ VERSION=v0.10.1
  ~                                                                                                                                                           ⎈ kind-skypilot  01:45:08
❯ helm upgrade --install retina oci://ghcr.io/microsoft/retina/charts/retina \
    --version $VERSION \
    --set image.tag=$VERSION \
    --set operator.tag=$VERSION \
    --set logLevel=info \
    --set enabledPlugin_linux="\[dropreason\,packetforward\,linuxutil\,dns\]"
Pulled: ghcr.io/microsoft/retina/charts/retina:v0.10.1
Digest: sha256:428fdcfc197b275cd41cf094b5bed4077b2eecad002a6ed31868e388ec7c42b3
Release "retina" has been upgraded. Happy Helming!
NAME: retina
LAST DEPLOYED: Mon Nov 18 01:45:11 2024
NAMESPACE: default
STATUS: deployed
REVISION: 3
NOTES:
1. Installing retina service using helm: helm install retina ./deploy/legacy/manifests/controller/helm/retina/ --namespace kube-system --dependency-update
2. Cleaning up/uninstalling/deleting retina and dependencies related:
  helm uninstall retina -n kube-system
  ~                                                                                                                                                                            01:45:11
❯ VERSION=v0.0.18
  ~                                                                                                                                                           ⎈ kind-skypilot  01:45:14
❯ helm upgrade --install retina oci://ghcr.io/microsoft/retina/charts/retina \
    --version $VERSION \
    --set image.tag=$VERSION \
    --set operator.tag=$VERSION \
    --set logLevel=info \
    --set enabledPlugin_linux="\[dropreason\,packetforward\,linuxutil\,dns\]"
Error: ghcr.io/microsoft/retina/charts/retina:v0.0.18: not found

@nddq
Copy link
Contributor

nddq commented Nov 18, 2024

hey @root-hbx , v0.0.18 is indeed Retina's latest version. I double checked that it is marked as latest on Github. The reason why we published v0.10.1 is so that we can retracted v0.10.0 which was mistakenly published.
Image

@root-hbx
Copy link
Author

hey @root-hbx , v0.0.18 is indeed Retina's latest version. I double checked that it is marked as latest on Github. The reason why we published v0.10.1 is so that we can retracted v0.10.0 which was mistakenly published. Image

Got it. Just to confirm, this issue will be fixed automatically since v0.10.2 ?

@nddq
Copy link
Contributor

nddq commented Nov 20, 2024

@root-hbx Since v0.10.1 and v0.10.0 are retracted, if a user is running those versions and they run go get github.com/microsoft/retina/@latest to update to the latest version, it should fall back v0.0.18

@root-hbx
Copy link
Author

@nddq Yes! Theoretically, it should return the v0.0.18 package. However, in my test above, it produces an error instead. What could be the reason for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants