Invalid URL message in Microsoft Block

[x-iy]

Moodle 4.1

Plugins
moodle-local_o365 - MOODLE_401_STABLE
moodle-block_microsoft - MOODLE_401_STABLE

Leaving $config->odburl empty in moodle-local_o365 settings results in Invalid URL message in moodle-block_microsoft

moodle-local_o365

moodle-block_microsoft

This is due to the onedrive and notebook urls being malformed here:
https://github.com/microsoft/moodle-local_o365/blob/MOODLE_401_STABLE/classes/rest/unified.php#L491

Which will throw an exception here:
https://github.com/microsoft/moodle-block_microsoft/blob/MOODLE_401_STABLE/block_microsoft.php#L186

Suggest unified::get_group_urls(object) should check if $config->odburl is empty before generating a malformed url for onedrive and notebook.

Resulting malformed urls:
https:///_layouts/groupstatus.aspx?id=xxxxxxx-xxxx-xxxx-xxxxxx&target=notebook
https:///_layouts/groupstatus.aspx?id=xxxxxxx-xxxx-xxxx-xxxxxx&target=documents

[weilai-irl]

Hi @x-iy

The fix to this issue has been included in release 4.1.7, 4.2.6 and 4.3.4 on 2nd of July 2024. Please check out the latest version of the plugins for the solution.

I'm going to mark this issue as closed.

Regards,
Lai