Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with binding.gyp file #665

Closed
legendSabbir opened this issue Feb 24, 2024 · 4 comments
Closed

Problem with binding.gyp file #665

legendSabbir opened this issue Feb 24, 2024 · 4 comments
Assignees

Comments

@legendSabbir
Copy link

Environment details

  • OS: Android
  • OS version:
  • node-pty version: 1.0.0
  • Terminal apk name: Termux

Issue description

Error while installing . Tried in many devices still same issue . Before it used to work . Stopped working recently .

gyp: Undefined variable android_ndk_path in binding.gyp while trying to load binding.gyp

IMG_20240224_191405_777

@bajrangCoder
Copy link

Yes, facing same issue.
And this issue started after recent node update (and also maybe due to node-gyp@10 version)

Tried some solution from internet but that doesn't work.

@Tyriar
Copy link
Member

Tyriar commented Feb 26, 2024

You're trying to install on Android? I wasn't aware this ever worked

@bajrangCoder
Copy link

You're trying to install on Android? I wasn't aware this ever worked

Previously it used to work.
Problem is it needs a "android_ndk_path" variable, but internally there is no need of this, if we will pass an empty android_ndk_path, but explicitly in node-gyp configure.js

Check out this 👉 termux/termux-packages#20717

@deepak1556
Copy link
Contributor

We are not configuring the mentioned variable in our binding.gyp, please confirm where the variable is being injected from and try to address it there.

@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants