Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weak reference handling in runtime object map #334

Merged
merged 2 commits into from
Jul 24, 2024

Add object-map test case

2a48504
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix weak reference handling in runtime object map #334

Add object-map test case
2a48504
Select commit
Loading
Failed to load commit list.
GitHub Actions / test results (macos-latest, net6.0, node20.x, Release) succeeded Jul 24, 2024 in 0s

79 passed, 0 failed and 13 skipped

Tests passed successfully

✅ test/net6.0-node20.x-Release/_Mac-1721842626021_2024-07-24_17_50_02.trx

92 tests were completed in 79s with 79 passed, 0 failed and 13 skipped.

Test suite Passed Failed Skipped Time
Microsoft.JavaScript.NodeApi.Test.GCTests 2⚪ 2ms
Microsoft.JavaScript.NodeApi.Test.HostedClrTests 34✅ 21s
Microsoft.JavaScript.NodeApi.Test.JSProjectTests 8✅ 57s
Microsoft.JavaScript.NodeApi.Test.JSReferenceTests 7✅ 7ms
Microsoft.JavaScript.NodeApi.Test.JSValueScopeTests 19✅ 8ms
Microsoft.JavaScript.NodeApi.Test.NodejsEmbeddingTests 11⚪ 11ms
Microsoft.JavaScript.NodeApi.Test.TypeDefsGeneratorTests 11✅ 24ms

✅ Microsoft.JavaScript.NodeApi.Test.GCTests

⚪ GCHandles
⚪ GCObjects

✅ Microsoft.JavaScript.NodeApi.Test.HostedClrTests

✅ Test(id: "edgejs-perf/measure-latency")
✅ Test(id: "napi-dotnet-init/custom_export")
✅ Test(id: "napi-dotnet-init/custom_init")
✅ Test(id: "napi-dotnet/async_methods")
✅ Test(id: "napi-dotnet/complex_types")
✅ Test(id: "napi-dotnet/delegates")
✅ Test(id: "napi-dotnet/dynamic_extensions")
✅ Test(id: "napi-dotnet/dynamic_generics")
✅ Test(id: "napi-dotnet/dynamic_invoke")
✅ Test(id: "napi-dotnet/dynamic_no_namespace_type")
✅ Test(id: "napi-dotnet/dynamic_optional_params")
✅ Test(id: "napi-dotnet/errors")
✅ Test(id: "napi-dotnet/hello")
✅ Test(id: "napi-dotnet/module_class")
✅ Test(id: "napi-dotnet/multi_instance")
✅ Test(id: "napi-dotnet/object_map")
✅ Test(id: "napi-dotnet/overloads")
✅ Test(id: "napi-dotnet/streams")
✅ Test(id: "napi-dotnet/thread_safety")
✅ Test(id: "node-addon-api/basic_types/array")
✅ Test(id: "node-addon-api/basic_types/boolean")
✅ Test(id: "node-addon-api/basic_types/number")
✅ Test(id: "node-addon-api/basic_types/value")
✅ Test(id: "node-addon-api/bigint")
✅ Test(id: "node-addon-api/object/delete_property")
✅ Test(id: "node-addon-api/object/finalizer")
✅ Test(id: "node-addon-api/object/get_property")
✅ Test(id: "node-addon-api/object/has_own_property")
✅ Test(id: "node-addon-api/object/has_property")
✅ Test(id: "node-addon-api/object/object_freeze_seal")
✅ Test(id: "node-addon-api/object/object")
✅ Test(id: "node-addon-api/object/set_property")
✅ Test(id: "node-addon-api/object/subscript_operator")
✅ Test(id: "node-addon-api/testUtil")

✅ Microsoft.JavaScript.NodeApi.Test.JSProjectTests

✅ Test(id: "projects/js-cjs-dynamic/net6.0")
✅ Test(id: "projects/js-cjs-module/net6.0")
✅ Test(id: "projects/js-esm-dynamic/net6.0")
✅ Test(id: "projects/js-esm-module/net6.0")
✅ Test(id: "projects/ts-cjs-dynamic/net6.0")
✅ Test(id: "projects/ts-cjs-module/net6.0")
✅ Test(id: "projects/ts-esm-dynamic/net6.0")
✅ Test(id: "projects/ts-esm-module/net6.0")

✅ Microsoft.JavaScript.NodeApi.Test.JSReferenceTests

✅ GetReferenceFromDifferentRootScope
✅ GetReferenceFromDifferentThread
✅ GetReferenceFromParentScope
✅ GetReferenceFromSameScope
✅ GetWeakReferenceUnavailable
✅ TryGetWeakReferenceUnavailable
✅ TryGetWeakReferenceValue

✅ Microsoft.JavaScript.NodeApi.Test.JSValueScopeTests

✅ AccessPropertyKeyFromClosedScope
✅ AccessValueFromClosedScope
✅ AccessValueFromDifferentRootScope
✅ AccessValueFromDifferentThread
✅ CreateCallbackScope
✅ CreateEscapableScopeWithinCallback
✅ CreateHandleScopeWithinCallback
✅ CreateHandleScopeWithinModule
✅ CreateHandleScopeWithinRoot
✅ CreateModuleScopeWithinNoContextScope
✅ CreateModuleScopeWithinRootScope
✅ CreateModuleScopeWithoutRoot
✅ CreateNoContextScope
✅ CreateRootScope
✅ CreateValueFromDifferentThread
✅ InvalidCallbackContextScopeNesting
✅ InvalidModuleContextScopeNesting
✅ InvalidNoContextScopeNesting
✅ InvalidRootContextScopeNesting

✅ Microsoft.JavaScript.NodeApi.Test.NodejsEmbeddingTests

⚪ CallFunction
⚪ ErrorPropagation
⚪ ImportBuiltinModule
⚪ ImportCommonJSModule
⚪ ImportCommonJSPackage
⚪ ImportESModule
⚪ ImportESPackage
⚪ MarshalClass
⚪ RestartEnvironment
⚪ StartEnvironment
⚪ UnhandledRejection

✅ Microsoft.JavaScript.NodeApi.Test.TypeDefsGeneratorTests

✅ GenerateEnum
✅ GenerateExtensionMethods
✅ GenerateGenericClass
✅ GenerateGenericDelegate
✅ GenerateGenericInterface
✅ GenerateJSDocLink
✅ GenerateSimpleClass
✅ GenerateSimpleDelegate
✅ GenerateSimpleInterface
✅ GenerateSimpleMethod
✅ GenerateSimpleProperty