Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for types/interfaces/delegates without namespaces #262

Open
DmitriySft opened this issue Apr 6, 2024 · 2 comments · Fixed by #265
Open

Add full support for types/interfaces/delegates without namespaces #262

DmitriySft opened this issue Apr 6, 2024 · 2 comments · Fixed by #265
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@DmitriySft
Copy link
Contributor

DmitriySft commented Apr 6, 2024

All kinds of .Net types without namespaces should be supported.
Currently, types without namespaces are just ignored.

  1. Class
  2. Structs
  3. Interfaces
  4. Enums
  5. Delegates
  6. etc.
@jasongin
Copy link
Member

jasongin commented Apr 8, 2024

I didn't mean to close this one with #265. Though that has some related fixes, I think there is still more work and testing to be done with un-namespaced types.

@jasongin jasongin reopened this Apr 8, 2024
@jasongin jasongin added this to the Version 1.0 milestone May 17, 2024
@jasongin jasongin self-assigned this Jun 17, 2024
@jasongin
Copy link
Member

#360 resolves issues with the module source generator and un-namespaced types.

Support for dynamic invocation of un-namespaced types is still not implemented. I am unsure whether it is a good idea to support that at all: with the way types from all loaded assemblies are merged into a combined namespace hierarchy, it could be easy to encounter name conflicts among un-namespaced types. The same is true for ordinary assembly references in C#, which is why it is a very bad practice to publish libraries without namespacing.

I am moving this issue to the Backlog milestone for future consideration. I don't think it's a priority right now.

@jasongin jasongin modified the milestones: Version 1.0, Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants