Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample docs on how to upload and update msix files #2

Open
green-munkey opened this issue Oct 14, 2023 · 9 comments
Open

Sample docs on how to upload and update msix files #2

green-munkey opened this issue Oct 14, 2023 · 9 comments
Labels
sample script request Request for a script sample covering a given scenario

Comments

@green-munkey
Copy link

Any plans on adding how to docs on how to upload a new msix app to intune ?

@Mahopper
Copy link
Contributor

Mahopper commented Nov 9, 2023

Hi @green-munkey, taking note on your request for a potential future msix LOB upload script sample. That being said, Win32/.intunewin samples will likely be prioritized first, as that has been more frequently requested in customer conversations.

@Mahopper Mahopper added sample script request Request for a script sample covering a given scenario enhancement New feature or request and removed sample script request Request for a script sample covering a given scenario enhancement New feature or request labels Nov 9, 2023
@mchaudoir
Copy link

Any progress for apps?

@Mahopper
Copy link
Contributor

@mchaudoir In progress. A new set of samples will be added in the coming weeks.

@SergiiMachulin
Copy link

SergiiMachulin commented Sep 13, 2024

Hi @Mahopper,

I wanted to check if there are any updates or a potential release date for this. It's quite important since we're aiming for a clear deployment process for Win32/.intunewin apps in Intune.

I've invested significant time to researching and testing various methods, but all the implementations or modules I found rely on outdated authentication approaches, and the workaround solutions haven't been successful either.

@Mahopper
Copy link
Contributor

Mahopper commented Sep 26, 2024

Hi @SergiiMachulin,

Acknowledging the ask here. We're aiming to publish a sample script covering Win32/.intunewin (including .MSI + .EXE) hopefully in October. Followed by other LOB app types.

@Mahopper
Copy link
Contributor

Mahopper commented Oct 8, 2024

@SergiiMachulin @mchaudoir

We've published a sample for uploading Win32 (intunewin) here: https://github.com/microsoft/mggraph-intune-samples/tree/main/LOB_Application

MSIX LOB will likely come at a later time, so keeping this item open for now.

@SergiiMachulin
Copy link

SergiiMachulin commented Oct 18, 2024

@Mahopper
There are a few issues in the function New-ProductCodeRule:

Incorrect Property Names in the Hashtable ($Rule):

The properties assigned to the hashtable don't match the parameter names. Specifically:
$operator and $comparisonValue are undefined variables. They should reference $productVersionOperator and $productVersion, respectively.
Missing Assignment for ruleType:

You are assigning properties to $Rule, but the ruleType parameter is not included in the hashtable.

function New-ProductCodeRule {
    param
    (
        [parameter(Mandatory = $true)]
        [ValidateSet('detection', 'requirement')]
        [string]$ruleType,

        [parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [string]$productCode,

        [parameter(Mandatory = $true)]
        [ValidateSet('notConfigured', 'equal', 'notEqual', 'greaterThan', 'greaterThanOrEqual', 'lessThan', 'lessThanOrEqual')]
        [string]$productVersionOperator,

        [parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [string]$productVersion
    )

    $Rule = @{}
    $Rule."@odata.type" = "#microsoft.graph.win32LobAppProductCodeRule"
    $Rule.productCode = $productCode
    $Rule.operator = $operator
    $Rule.comparisonValue = $comparisonValue

    return $Rule
}

@Mahopper
Copy link
Contributor

@SergiiMachulin

Ack, thanks for the feedback. Should be able to investigate this in the next week or so.

@Mahopper
Copy link
Contributor

@Mahopper There are a few issues in the function New-ProductCodeRule:

Incorrect Property Names in the Hashtable ($Rule):

The properties assigned to the hashtable don't match the parameter names. Specifically: $operator and $comparisonValue are undefined variables. They should reference $productVersionOperator and $productVersion, respectively. Missing Assignment for ruleType:

You are assigning properties to $Rule, but the ruleType parameter is not included in the hashtable.

function New-ProductCodeRule {
    param
    (
        [parameter(Mandatory = $true)]
        [ValidateSet('detection', 'requirement')]
        [string]$ruleType,

        [parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [string]$productCode,

        [parameter(Mandatory = $true)]
        [ValidateSet('notConfigured', 'equal', 'notEqual', 'greaterThan', 'greaterThanOrEqual', 'lessThan', 'lessThanOrEqual')]
        [string]$productVersionOperator,

        [parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [string]$productVersion
    )

    $Rule = @{}
    $Rule."@odata.type" = "#microsoft.graph.win32LobAppProductCodeRule"
    $Rule.productCode = $productCode
    $Rule.operator = $operator
    $Rule.comparisonValue = $comparisonValue

    return $Rule
}

Hi @SergiiMachulin

This should now be resolved with this PR: #18

Please let me know if you run into any issues.

Thanks, Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sample script request Request for a script sample covering a given scenario
Projects
None yet
Development

No branches or pull requests

4 participants