Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Use param objects where they make sense for named variables. #750

Open
huntj88 opened this issue Feb 6, 2024 · 0 comments · May be fixed by #794
Open

[Feature Request]: Use param objects where they make sense for named variables. #750

huntj88 opened this issue Feb 6, 2024 · 0 comments · May be fixed by #794
Labels
enhancement New feature or request live-share-v2

Comments

@huntj88
Copy link
Contributor

huntj88 commented Feb 6, 2024

Describe your user scenario
We have several places where we have a bunch of flags, or optional variables.

Instead of seeing something like

// no longer optional
const optionalValue: any | undefined = undefined;

someFunctionCall(true, true, false, optionalValue, true);

I would prefer to see param objects where they make sense for named variables.

// optional value not included.
// easier understanding of how flags are set.
someFunctionCall({
  optionA: true,
  optionB: true,
  optionC: false,
  optionD: true,
});

Places to consider

  • LiveObjectSynchronizer.start()
  • LiveMediaSession_Synchronizer.spec.getObjects()
  • LivePresence.updateInternal()
  • TODO: Definitely are more
@huntj88 huntj88 added enhancement New feature or request new submission Issues that have been filed and not yet processed by DRI labels Feb 6, 2024
@ryanbliss ryanbliss added live-share-v2 and removed new submission Issues that have been filed and not yet processed by DRI labels Feb 8, 2024
@ryanbliss ryanbliss linked a pull request Aug 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request live-share-v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants