Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Remove registerClientId #740

Open
ryanbliss opened this issue Jan 18, 2024 · 0 comments
Open

[Feature Request]: Remove registerClientId #740

ryanbliss opened this issue Jan 18, 2024 · 0 comments
Labels
enhancement New feature or request sdk work teams client work work related to Live Share that requires work on the Teams client

Comments

@ryanbliss
Copy link
Contributor

We have found that the ILiveShareHost registerClientId() function is not actually necessary. Because userId is included in the Fluid token, we can safely have each client get the Teams userId from Fluid audience, and then use the userId for things like role verification (rather than clientId).
@ryanbliss ryanbliss added enhancement New feature or request live-share-v2 labels Jan 18, 2024
@ryanbliss ryanbliss added sdk work teams client work work related to Live Share that requires work on the Teams client and removed live-share-v2 labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request sdk work teams client work work related to Live Share that requires work on the Teams client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanbliss