Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][LiveCanvas]: Laser Pointer and highlighter first and last position persists for non local clients #723

Open
huntj88 opened this issue Oct 2, 2023 · 0 comments · May be fixed by #794
Open

[Bug][LiveCanvas]: Laser Pointer and highlighter first and last position persists for non local clients #723

huntj88 opened this issue Oct 2, 2023 · 0 comments · May be fixed by #794
Labels
bug Something isn't working live share canvas work Work related to the live-share-canvas sdk package

Comments

@huntj88
Copy link
Contributor

huntj88 commented Oct 2, 2023 •
edited
Loading

Laser Pointer and highlighter first and last position persists for non local clients, and cannot be deleted.

This was reproduced with the react version of LiveCanvas, in a sample where LiveCanvas was periodically added and removed from the DOM.

Expected behavior

Laser pointer should fully fade, highlighting should disappear fully after deleting.

Screenshots

image
@huntj88 huntj88 added bug Something isn't working new submission Issues that have been filed and not yet processed by DRI labels Oct 2, 2023
@ryanbliss ryanbliss added live share canvas work Work related to the live-share-canvas sdk package and removed new submission Issues that have been filed and not yet processed by DRI labels Oct 9, 2023
@ryanbliss ryanbliss mentioned this issue Jul 3, 2024
Merged
@ryanbliss ryanbliss linked a pull request Aug 29, 2024 that will close this issue
Live Share SDK 2.0.0 #794
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working live share canvas work Work related to the live-share-canvas sdk package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Live Share SDK 2.0.0 microsoft/live-share-sdk
2 participants
@huntj88 @ryanbliss