Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Seek after pause to ensure paused frame is consistent for all users #199

Open
1 task done
ryanbliss opened this issue Nov 28, 2022 · 1 comment
Open
1 task done
Labels
live share media work Work related to the live-share-media sdk package sdk work work item

Comments

@ryanbliss
Copy link
Contributor

Please review FAQ and Known issues before filing a new item!

  • I have reviewed the FAQ and known issues and did not find my topic

Describe your user scenario

When a user pauses a media player, other users should seek to that exact position so it is paused on the same frame. This is important for scenarios where Live Canvas is being used in parallel with a paused video.

Describe the solution you'd like

When a pause event is emitted through LiveMediaSession, clients that receive that event should pause and then seek the video to the timestamp of the user that emitted the pause event.

We may want to consider making this something that developers can disable but make it on by default.

@ryanbliss ryanbliss added enhancement New feature or request new submission Issues that have been filed and not yet processed by DRI sdk work live share media work Work related to the live-share-media sdk package work item and removed enhancement New feature or request new submission Issues that have been filed and not yet processed by DRI labels Nov 28, 2022
@ryanbliss ryanbliss changed the title [Feature Request]: Seek after pause to ensure paused frame is consistent for all users [TASK]: Seek after pause to ensure paused frame is consistent for all users Dec 2, 2022
@ryanbliss ryanbliss changed the title [TASK]: Seek after pause to ensure paused frame is consistent for all users [Task]: Seek after pause to ensure paused frame is consistent for all users Dec 2, 2022
@huntj88
Copy link
Contributor

huntj88 commented Feb 8, 2024

if they are only a little bit behind (few hundred milliseconds), probably just let it play until they get to the same position as the pause. If too far behind, or slightly ahead seek to pause position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
live share media work Work related to the live-share-media sdk package sdk work work item
Projects
None yet
Development

No branches or pull requests

2 participants