Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data as a parameter to visualize #132

Open
Jesusdiazrivero opened this issue Aug 8, 2024 · 1 comment
Open

Add data as a parameter to visualize #132

Jesusdiazrivero opened this issue Aug 8, 2024 · 1 comment

Comments

@Jesusdiazrivero
Copy link

It should be possible to pass data to the visualize function instead of having to call summarize each time.

Currently the visualize function is essentially limited to reading the data acquired during summarization step or reading from a file in a very specific location.

Suggest a small change to the function so that data can be passed as a parameter instead of read from self. The manager can then pass data this way too.

@Jesusdiazrivero
Copy link
Author

I have the change ready, but for some reason am being hit with a "Pull request creation failed. Validation failed: must be a collaborator" error when I try to create the PR. I committed on a forked repo, trying to PR to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant