Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow writing to existing keys mapped to a slot in migrating state. #354

Open
priyanjgupta opened this issue May 2, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@priyanjgupta
Copy link

priyanjgupta commented May 2, 2024

Feature request type

enhancement

Is your feature request related to a problem? Please describe

Currently if a slot is in migrating state and we try to write to an existing key mapped to that slot, we encounter a -MIGRATING error, resulting in write failures.

Describe the solution you'd like

As per my understanding

  1. The existing keys which have not yet been migrated should be served by the source node, whether it's a read or a write.
  2. And for the keys which have been migrated to some other node, the write requests should return a -ASK redirect to guide the client to the target node

With this solution, the write availability improves for the existing keys in the migrating slot.

Describe alternatives you've considered

No response

Additional context

With redis following is the read/write request behaviour for keys mapped to the migrating slot
image

For context:
image

@darrenge darrenge added the enhancement New feature or request label May 2, 2024
@vazois vazois self-assigned this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants