You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
kolaps33
changed the title
[Bug]: Dialog, popover trigger should have better aria role
[Bug]: Dialog, popover trigger should have aria-haspopup attribute
Dec 16, 2024
kolaps33
changed the title
[Bug]: Dialog, popover trigger should have aria-haspopup attribute
[Bug]: Dialog, popover trigger should has aria-haspopup attribute
Dec 16, 2024
layershifter
changed the title
[Bug]: Dialog, popover trigger should has aria-haspopup attribute
[Bug]: Dialog, popover trigger should have aria-haspopup attribute
Dec 17, 2024
Component
Popover
Package version
9.56.6
React version
18.3.1
Environment
Current Behavior
the trigger element which opens dialog has aria attribute
aria-expanded="false"
https://react.fluentui.dev/?path=/docs/components-popover--docs#trapping-focus
Expected Behavior
The element should have attribute
aria-haspopup="dialog"
Current Narration of
aria-haspopup="dialog"
is following:NVDA: ... button opens dialog
JAWS: ... button Has Popup dialog
Narrator: ... Button Has Popup
VoiceOver: ... dialog popup button
would be good to consider for fix as well dialog component
For dialog: https://react.fluentui.dev/?path=/docs/components-dialog--docs#default I cannot see any attribute added.
Be careful: we should add
aria-haspopup
only for popover which opens dialog, not others popover...Reproduction
https://stackblitz.com/edit/zpkcyref?file=src%2Fexample.tsx
Steps to reproduce
Are you reporting an Accessibility issue?
None
Suggested severity
High - No workaround
Products/sites affected
teams
Are you willing to submit a PR to fix?
no
Validations
The text was updated successfully, but these errors were encountered: