Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dialog, popover trigger should have aria-haspopup attribute #33478

Open
2 tasks done
kolaps33 opened this issue Dec 16, 2024 · 0 comments
Open
2 tasks done

[Bug]: Dialog, popover trigger should have aria-haspopup attribute #33478

kolaps33 opened this issue Dec 16, 2024 · 0 comments

Comments

@kolaps33
Copy link
Contributor

kolaps33 commented Dec 16, 2024

Component

Popover

Package version

9.56.6

React version

18.3.1

Environment

System:
    OS: Windows 11 10.0.22631
    CPU: (22) x64 Intel(R) Core(TM) Ultra 7 165H
    Memory: 33.96 GB / 63.64 GB
  Browsers:
    Edge: Chromium (127.0.2651.74)
    Internet Explorer: 11.0.22621.3527

Current Behavior

the trigger element which opens dialog has aria attribute aria-expanded="false"

https://react.fluentui.dev/?path=/docs/components-popover--docs#trapping-focus

Expected Behavior

The element should have attribute aria-haspopup="dialog"

Current Narration of aria-haspopup="dialog" is following:
NVDA: ... button opens dialog
JAWS: ... button Has Popup dialog
Narrator: ... Button Has Popup
VoiceOver: ... dialog popup button

would be good to consider for fix as well dialog component
For dialog: https://react.fluentui.dev/?path=/docs/components-dialog--docs#default I cannot see any attribute added.

Be careful: we should add aria-haspopup only for popover which opens dialog, not others popover...

Reproduction

https://stackblitz.com/edit/zpkcyref?file=src%2Fexample.tsx

Steps to reproduce

  1. Go to stackblitz
  2. verify aria attribute for the button

Are you reporting an Accessibility issue?

None

Suggested severity

High - No workaround

Products/sites affected

teams

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@kolaps33 kolaps33 changed the title [Bug]: Dialog, popover trigger should have better aria role [Bug]: Dialog, popover trigger should have aria-haspopup attribute Dec 16, 2024
@kolaps33 kolaps33 changed the title [Bug]: Dialog, popover trigger should have aria-haspopup attribute [Bug]: Dialog, popover trigger should has aria-haspopup attribute Dec 16, 2024
@layershifter layershifter changed the title [Bug]: Dialog, popover trigger should has aria-haspopup attribute [Bug]: Dialog, popover trigger should have aria-haspopup attribute Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants