-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: TimePicker + Date Picker issue #33450
Comments
Hi @uValerion, the codepen link you included for the repro is not working for me, it's giving a 500 server error. Could you include a fixed repro link? I tried it on the example in the documentation site, and was not able to reproduce the behavior described in the issue. https://react.fluentui.dev/?path=/docs/compat-components-timepicker--docs#time-picker-with-date-picker |
Hi Ben,
In the fluent UI documentation for react components, in the time picker
component there is an example for TimePicker and DatePicker combo
There you can reproduce it with no changes necessary
Just set the timepicker to 00:00 and try to go back with the date picker 1
day
…On Wed, 11 Dec 2024 at 22:45 Ben Howell ***@***.***> wrote:
Hi @uValerion <https://github.com/uValerion>, the codepen link you
included for the repro is not working for me, it's giving a 500 server
error. Could you include a fixed repro link?
I tried it on the example in the documentation site, and was not able to
reproduce the behavior described in the issue.
https://react.fluentui.dev/?path=/docs/compat-components-timepicker--docs#time-picker-with-date-picker
—
Reply to this email directly, view it on GitHub
<#33450 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN7IQOEBQXU3ZSTZRZZW6GT2FCP5ZAVCNFSM6AAAAABTN5JWRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGEYTAMRVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
microsoft-github-policy-service
bot
added
Needs: Attention
and removed
Needs: Author Feedback
labels
Dec 11, 2024
Hi Ben,
This bug was a 100% repro for me,
But after a computer restart I see that it is no longer the case, I guess
this was a caching issue
Thanks and Sorry for the trouble
…On Wed, 11 Dec 2024 at 23:21 Yuval Dahan ***@***.***> wrote:
Hi Ben,
In the fluent UI documentation for react components, in the time picker
component there is an example for TimePicker and DatePicker combo
There you can reproduce it with no changes necessary
Just set the timepicker to 00:00 and try to go back with the date picker 1
day
On Wed, 11 Dec 2024 at 22:45 Ben Howell ***@***.***> wrote:
> Hi @uValerion <https://github.com/uValerion>, the codepen link you
> included for the repro is not working for me, it's giving a 500 server
> error. Could you include a fixed repro link?
>
> I tried it on the example in the documentation site, and was not able to
> reproduce the behavior described in the issue.
> https://react.fluentui.dev/?path=/docs/compat-components-timepicker--docs#time-picker-with-date-picker
>
> —
> Reply to this email directly, view it on GitHub
> <#33450 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AN7IQOEBQXU3ZSTZRZZW6GT2FCP5ZAVCNFSM6AAAAABTN5JWRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGEYTAMRVGA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component
TimePicker (Compat)
Package version
8.121.13
React version
17.0.53
Environment
Current Behavior
If Time Picker is set to 00:00:00, date picker cannot go back 1 day. (only 1 day)
Expected Behavior
If Time Picker is set to 00:00:00, date picker shoukld be able to go back 1 day.
https://github.com/user-attachments/assets/f0a64b6e-3526-413f-a7b3-ccd4a5f7ae60
Reproduction
https://codepen.io/pen?&prefill_data_id=be6eee72-b501-4177-88b0-9eef2b90d277
Steps to reproduce
set time picker to 00:00
try to go back 1 day (Jan 01, 2023)
Are you reporting an Accessibility issue?
None
Suggested severity
Medium - Has workaround
Products/sites affected
No response
Are you willing to submit a PR to fix?
no
Validations
The text was updated successfully, but these errors were encountered: