Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: overhaul lint setup within monorepo #32289

Open
2 of 3 tasks
Hotell opened this issue Aug 13, 2024 · 0 comments
Open
2 of 3 tasks

[Feature]: overhaul lint setup within monorepo #32289

Hotell opened this issue Aug 13, 2024 · 0 comments

Comments

@Hotell
Copy link
Contributor

Hotell commented Aug 13, 2024

Library

React Components / v9 (@fluentui/react-components)

Pre-requirements:

Describe the feature that you would like added

From historically reasons @fluentui/eslint-plugin project was the only place that implemented custom rules used within monorepo and across project domain boundaries. This state of things is hard to maintain, extend and understand.

We need to overhaul current implementation and how we setup our lint configuration within projects.

Setup

  • migrate to eslint flat configs
  • configs extends from monorepo root eslint config, rather than using npm package names

Architecture

workspace specific rule lives within workspace eslint-rules project

we have plugin per domain:

note these plugins will be probably public and shipped to npm in order to consume these within other fluent projects/fluent users

  • fluent-react-plugin
  • fluent-react-components-plugin
  • fluent-node-plugin
  • fluent-*-plugin

Have you discussed this feature with our team

@microsoft/react-fliuent-build

Additional context

No response

Validations

  • Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

Priority

Normal

Related Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants